From: Joe Perches <joe@perches.com>
To: Jerome Pouiller <Jerome.Pouiller@silabs.com>,
Jules Irenge <jbi.octave@gmail.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] staging: wfx: replace u32 by __le32
Date: Mon, 11 Nov 2019 15:15:54 -0800 [thread overview]
Message-ID: <c2c803570b92fc18ac62902bd99075ccc33eb5b6.camel@perches.com> (raw)
In-Reply-To: <3445403.d56fhTCmfW@pc-42>
On Mon, 2019-11-11 at 16:58 +0000, Jerome Pouiller wrote:
> On Monday 11 November 2019 14:30:55 CET Jules Irenge wrote:
> [...]
> > - u32 count_rts_failures;
> > - u32 count_ack_failures;
> > - u32 count_rx_multicast_frames;
> > - u32 count_rx_frames_success;
> > - u32 count_rx_cmacicv_errors;
> > - u32 count_rx_cmac_replays;
> > - u32 count_rx_mgmt_ccmp_replays;
> [...]
> > + __le32 count_rts_failures;
> > + __le32 count_rx_multicast_frames;
> > + __le32 count_rx_cmacicv_errors;
> > + __le32 count_rx_cmac_replays;
> > + __le32 count_rx_mgmt_ccmp_replays;
> > + __le32 count_rx_beacon;
> > + __le32 count_miss_beacon;
> > + __le32 count_ack_failures;
> > + __le32 count_rx_frames_success;
> > u32 count_rx_bipmic_errors;
> > - u32 count_rx_beacon;
> > - u32 count_miss_beacon;
>
> Hello Jules,
>
> Your patch reorders members of the structure. It will break API with the
> chip.
And if the hardware really is le, then almost certainly
_all_ the members of the struct should be __le32
next prev parent reply other threads:[~2019-11-11 23:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 13:30 [PATCH v2 1/3] staging: wfx: replace uintXX_t to uXX and intXX_t to sXX Jules Irenge
2019-11-11 13:30 ` [PATCH v2 2/3] staging: wfx: wrap characters Jules Irenge
2019-11-11 15:34 ` Greg KH
2019-11-11 13:30 ` [PATCH v2 3/3] staging: wfx: replace u32 by __le32 Jules Irenge
2019-11-11 14:12 ` Greg KH
2019-11-11 16:58 ` Jerome Pouiller
2019-11-11 23:15 ` Joe Perches [this message]
2019-11-11 17:04 ` [PATCH v2 1/3] staging: wfx: replace uintXX_t to uXX and intXX_t to sXX Jerome Pouiller
2019-11-11 17:48 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2c803570b92fc18ac62902bd99075ccc33eb5b6.camel@perches.com \
--to=joe@perches.com \
--cc=Jerome.Pouiller@silabs.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbi.octave@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).