From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Shuah Khan <shuahkh@osg.samsung.com>,
mchehab@kernel.org, hansverk@cisco.com, kgene@kernel.org,
krzk@kernel.org, s.nawrocki@samsung.com,
shailendra.v@samsung.com, shuah@kernel.org, Julia.Lawall@lip6.fr,
kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com,
a.hajda@samsung.com
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 0/2] fix lockdep warnings in s5p_mfc and exynos-gsc vb2 drivers
Date: Mon, 16 Oct 2017 14:48:54 +0200 [thread overview]
Message-ID: <c2dae5ff-a35c-bdd1-910b-75db6c9c16b2@samsung.com> (raw)
In-Reply-To: <cover.1507935819.git.shuahkh@osg.samsung.com>
Hi Shuah,
On 2017-10-14 01:13, Shuah Khan wrote:
> Driver mmap functions shouldn't hold lock when calling vb2_mmap(). The
> vb2_mmap() function has its own lock that it uses to protect the critical
> section.
>
> Reference: commit log for f035eb4e976ef5a059e30bc91cfd310ff030a7d3
It would make sense to add the information about the reference commit to
each
commit message and also point to commit
e752577ed7bf55c81e10343fced8b378cda2b63b,
as it is exactly the same case here. Anyway:
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
I wonder if makes sense to send those patches also to stable@vget.kernel.org
(maybe v4.3+, like the mentioned above commit, if they really apply?).
> Shuah Khan (2):
> media: exynos-gsc: fix lockdep warning
> media: s5p-mfc: fix lockdep warning
>
> drivers/media/platform/exynos-gsc/gsc-m2m.c | 5 -----
> drivers/media/platform/s5p-mfc/s5p_mfc.c | 3 ---
> 2 files changed, 8 deletions(-)
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2017-10-16 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171013231531epcas5p2f009317ed58f5177e7a0768b69a62b6c@epcas5p2.samsung.com>
2017-10-13 23:13 ` [PATCH 0/2] fix lockdep warnings in s5p_mfc and exynos-gsc vb2 drivers Shuah Khan
2017-10-13 23:13 ` [PATCH 1/2] media: exynos-gsc: fix lockdep warning Shuah Khan
2017-10-16 15:18 ` [PATCH v2 " Hans Verkuil
2017-11-07 16:53 ` Shuah Khan
2017-12-08 22:58 ` Shuah Khan
2017-10-13 23:13 ` [PATCH 2/2] media: s5p-mfc: " Shuah Khan
2017-10-16 15:18 ` [PATCH v2 " Hans Verkuil
2017-10-16 12:48 ` Marek Szyprowski [this message]
2017-10-16 14:51 ` [PATCH 0/2] fix lockdep warnings in s5p_mfc and exynos-gsc vb2 drivers Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2dae5ff-a35c-bdd1-910b-75db6c9c16b2@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=Julia.Lawall@lip6.fr \
--cc=a.hajda@samsung.com \
--cc=hansverk@cisco.com \
--cc=jtp.park@samsung.com \
--cc=kamil@wypas.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=shailendra.v@samsung.com \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).