From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61AC4C433DF for ; Tue, 2 Jun 2020 11:10:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37834206C3 for ; Tue, 2 Jun 2020 11:10:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B9IEMppM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726450AbgFBLKx (ORCPT ); Tue, 2 Jun 2020 07:10:53 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:22279 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725919AbgFBLKx (ORCPT ); Tue, 2 Jun 2020 07:10:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591096251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e1bN6BFwrFb8HaDkHCOaH4+Ma1lbuG7/W6ik/b1HbRs=; b=B9IEMppMxroekJlIZoIy4zVaMvQVnEhSqo2IYoTdq8SkT417pbsjLv09IoQ73nEFKVXpd7 9MZgX/hzbd1IqrIhj3r4pL+jasgrYVWdoxspG5FdNbEYlrJDAfWTOmvJNDHBoTDdLufWoZ MHubp9EDaYWMuAQROHqohWOVwIJw8aM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-peAYYSG6MtaV1fKxi7DMpw-1; Tue, 02 Jun 2020 07:10:49 -0400 X-MC-Unique: peAYYSG6MtaV1fKxi7DMpw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EDEAA1883607; Tue, 2 Jun 2020 11:10:46 +0000 (UTC) Received: from [10.72.12.83] (ovpn-12-83.pek2.redhat.com [10.72.12.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id A75B578EFB; Tue, 2 Jun 2020 11:10:39 +0000 (UTC) Subject: Re: [PATCH] vdpa: bypass waking up vhost_woker for vdpa vq kick From: Jason Wang To: Dan Carpenter , kbuild@lists.01.org, Zhu Lingshan , mst@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: lkp@intel.com, kbuild-all@lists.01.org, lulu@redhat.com, dan.daly@intel.com, cunming.liang@intel.com References: <20200602094203.GU30374@kadam> Message-ID: Date: Tue, 2 Jun 2020 19:10:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/6/2 下午6:16, Jason Wang wrote: > > On 2020/6/2 下午5:42, Dan Carpenter wrote: >> Hi Zhu, >> >> url: >> https://github.com/0day-ci/linux/commits/Zhu-Lingshan/vdpa-bypass-waking-up-vhost_woker-for-vdpa-vq-kick/20200526-133819 >> >> base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git >> linux-next >> config: x86_64-randconfig-m001-20200529 (attached as .config) >> compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kbuild test robot >> Reported-by: Dan Carpenter >> >> smatch warnings: >> drivers/vhost/vdpa.c:348 vhost_vdpa_set_vring_kick() error: >> uninitialized symbol 'r'. >> >> # >> https://github.com/0day-ci/linux/commit/a84ddbf1ef29f18aafb2bb8a93bcedd4a29a967d >> >> git remote add linux-review https://github.com/0day-ci/linux >> git remote update linux-review >> git checkout a84ddbf1ef29f18aafb2bb8a93bcedd4a29a967d >> vim +/r +348 drivers/vhost/vdpa.c >> >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  316  static long >> vhost_vdpa_set_vring_kick(struct vhost_virtqueue *vq, >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 317                        >> void __user *argp) >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  318  { >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  319      bool pollstart = >> false, pollstop = false; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  320      struct file >> *eventfp, *filep = NULL; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  321      struct >> vhost_vring_file f; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  322      long r; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  323 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  324      if >> (copy_from_user(&f, argp, sizeof(f))) >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  325          return -EFAULT; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  326 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  327      eventfp = f.fd == -1 >> ? NULL : eventfd_fget(f.fd); >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  328      if (IS_ERR(eventfp)) { >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  329          r = >> PTR_ERR(eventfp); >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  330          return r; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  331      } >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  332 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  333      if (eventfp != >> vq->kick) { >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  334          pollstop = >> (filep = vq->kick) != NULL; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  335          pollstart = >> (vq->kick = eventfp) != NULL; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  336      } else >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  337          filep = eventfp; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  338 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  339      if (pollstop && >> vq->handle_kick) >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  340 vhost_vdpa_poll_stop(vq); >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  341 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  342      if (filep) >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  343 fput(filep); >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  344 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  345      if (pollstart && >> vq->handle_kick) >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  346          r = >> vhost_vdpa_poll_start(vq); >> >> "r" not initialized on else path. >> >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  347 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 @348      return r; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26  349  } > > > Will fix. > > Thanks Lingshan reminds me that we've posted V2 which reuses the vhost.c implementation for polling. So there's no need for the fix. Thanks