From: Randy Dunlap <rdunlap@infradead.org>
To: Nathan Chancellor <natechancellor@gmail.com>,
Robert Moore <robert.moore@intel.com>,
Erik Kaneda <erik.kaneda@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-acpi@vger.kernel.org, devel@acpica.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI / NUMA: Add stub function for pxm_to_node
Date: Tue, 29 Sep 2020 13:13:24 -0700 [thread overview]
Message-ID: <c313dcd3-7fab-00eb-15f2-65a3a51f7bd5@infradead.org> (raw)
In-Reply-To: <20200928194554.3423466-1-natechancellor@gmail.com>
On 9/28/20 12:45 PM, Nathan Chancellor wrote:
> After commit 01feba590cd6 ("ACPI: Do not create new NUMA domains from
> ACPI static tables that are not SRAT"):
>
> $ scripts/config --file arch/x86/configs/x86_64_defconfig -d NUMA -e ACPI_NFIT
>
> $ make -skj"$(nproc)" distclean defconfig drivers/acpi/nfit/
> drivers/acpi/nfit/core.c: In function ‘acpi_nfit_register_region’:
> drivers/acpi/nfit/core.c:3010:27: error: implicit declaration of
> function ‘pxm_to_node’; did you mean ‘xa_to_node’?
> [-Werror=implicit-function-declaration]
> 3010 | ndr_desc->target_node = pxm_to_node(spa->proximity_domain);
> | ^~~~~~~~~~~
> | xa_to_node
> cc1: some warnings being treated as errors
> ...
>
> Add a stub function like acpi_map_pxm_to_node had so that the build
> continues to work.
>
> Fixes: 01feba590cd6 ("ACPI: Do not create new NUMA domains from ACPI static tables that are not SRAT")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
>
> I am not sure if this is the right place or value for this. It looks
> like there is going to be another stub function added here, which is
> going through -mm:
>
> https://lkml.kernel.org/r/159643094925.4062302.14979872973043772305.stgit@dwillia2-desk3.amr.corp.intel.com
>
> include/acpi/acpi_numa.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/acpi/acpi_numa.h b/include/acpi/acpi_numa.h
> index fdebcfc6c8df..09eb3bc20ff5 100644
> --- a/include/acpi/acpi_numa.h
> +++ b/include/acpi/acpi_numa.h
> @@ -22,5 +22,10 @@ extern int acpi_numa __initdata;
> extern void bad_srat(void);
> extern int srat_disabled(void);
>
> +#else /* CONFIG_ACPI_NUMA */
> +static inline int pxm_to_node(int pxm)
> +{
> + return 0;
> +}
> #endif /* CONFIG_ACPI_NUMA */
> #endif /* __ACP_NUMA_H */
>
> base-commit: eb6335b68ce3fc85a93c4c6cd3bb6bc5ac490efe
OK, that works/builds. It doesn't quite apply cleanly to linux-next-20200929
but that's a minor detail and easy to get around.
Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
--
~Randy
next prev parent reply other threads:[~2020-09-29 20:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 19:45 [PATCH] ACPI / NUMA: Add stub function for pxm_to_node Nathan Chancellor
2020-09-29 20:13 ` Randy Dunlap [this message]
2020-09-30 8:42 ` Jonathan Cameron
2020-09-30 9:07 ` Hanjun Guo
2020-09-30 15:49 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c313dcd3-7fab-00eb-15f2-65a3a51f7bd5@infradead.org \
--to=rdunlap@infradead.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=devel@acpica.org \
--cc=erik.kaneda@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).