From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C66D8C7618B for ; Fri, 26 Jul 2019 09:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9EAF922CBA for ; Fri, 26 Jul 2019 09:55:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726074AbfGZJzE (ORCPT ); Fri, 26 Jul 2019 05:55:04 -0400 Received: from mga05.intel.com ([192.55.52.43]:9014 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbfGZJzD (ORCPT ); Fri, 26 Jul 2019 05:55:03 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 02:55:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,310,1559545200"; d="scan'208";a="175549843" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.251.89.116]) ([10.251.89.116]) by orsmga006.jf.intel.com with ESMTP; 26 Jul 2019 02:54:57 -0700 Subject: Re: [RFC PATCH 09/40] soundwire: cadence_master: fix usage of CONFIG_UPDATE From: Cezary Rojewski To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com, Sanyog Kale References: <20190725234032.21152-1-pierre-louis.bossart@linux.intel.com> <20190725234032.21152-10-pierre-louis.bossart@linux.intel.com> <980e074e-0736-1b17-266b-2ef0ae7d7823@intel.com> Message-ID: Date: Fri, 26 Jul 2019 11:54:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <980e074e-0736-1b17-266b-2ef0ae7d7823@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-07-26 11:53, Cezary Rojewski wrote: > On 2019-07-26 01:40, Pierre-Louis Bossart wrote: >>   /* >>    * debugfs >>    */ >> @@ -758,15 +774,9 @@ static int _cdns_enable_interrupt(struct sdw_cdns >> *cdns) >>    */ >>   int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns) >>   { >> -    int ret; >> - >>       _cdns_enable_interrupt(cdns); >> -    ret = cdns_clear_bit(cdns, CDNS_MCP_CONFIG_UPDATE, >> -                 CDNS_MCP_CONFIG_UPDATE_BIT); >> -    if (ret < 0) >> -        dev_err(cdns->dev, "Config update timedout\n"); >> -    return ret; >> +    return 0; >>   } >>   EXPORT_SYMBOL(sdw_cdns_enable_interrupt); > > Rather than ignoring _cdns_enable_interrupt - despite said func always > returning 0 - simply do: return _cnds_enable_interrupt(cdns) and flag > caller with inline. > > Afterwards, one can think if such encapsulation is even required - > remove existing sdw_cdns_enable_interrupt and rename > _cnds_enable_interrupt? Nevermind, I see you simplified it in the next patch..