From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756325AbcHXSqn (ORCPT ); Wed, 24 Aug 2016 14:46:43 -0400 Received: from mout.web.de ([212.227.15.4]:59032 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753888AbcHXSql (ORCPT ); Wed, 24 Aug 2016 14:46:41 -0400 Subject: [PATCH v2 1/2] KVM: s390: Improve determination of sizes in kvm_s390_import_bp_data() To: kvm@vger.kernel.org, linux-s390@vger.kernel.org, =?UTF-8?Q?Christian_Borntr=c3=a4ger?= , Cornelia Huck , David Hildenbrand , Heiko Carstens , Martin Schwidefsky , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <82b84c9c-38a4-4d17-910f-312668dbae01@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Walter Harms From: SF Markus Elfring Message-ID: Date: Wed, 24 Aug 2016 20:36:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:SDa2NnXwQ0jDtrNrQCCNnb3/HRquh+eZOWudL7RScoW6vfMeoZY 1b3IP1iFrM8jKk2RSCSn8W7hVbK9i7jrHaVH6eni29hQyFg4NAC6ImFAEDgBfT8nzl/E18V VLK+KU/7pVdbbot1NgVwMP2YRZ2McHY9f8iK3CtfDKzHHEXNzkZOdisRese7B8inY/C9g9r YpopXdNz4aZJSdf4j8d/w== X-UI-Out-Filterresults: notjunk:1;V01:K0:mWpj3zplyKU=:v99+GU9RcSJ0e6WoFuKegd 8+/OFnjo8WedRFCkoox+fGFGem6lWsF40P50eSUeagOodYmZ7ol3e7LMQU2/xFOmmRDdYikmY iRAnz1dKj0ctRl98QowV771xe+xdYP1DKPJ1XlnOZCfw1KVTQU6pv5Ebl5cKpckX5fXYD3pmp OSjU4Cwj2jVIRZXjvmppqMVAnd3m4xIAlvpF7oiUZspfbQKKLX+ch+e2lq42Q5Qv5UTMlHZse nycSBZjqZ05C1SO47vFmvGXK8cng6NVS7gtO4GGbd14Y5Df63IhIior7Ci+pWcNlAJNqLqatK ngfGy5tmgUeLA1NNPBsaRPK6sc/7sEs/5Z3UQgDPCKMYMZBVADi9eRFwZELVngMapCx/havZC 02+jIp5j8NxSwy73no5G1/5ivurIFRYeb7vmeVA8RzPhjWwMb1qWJe8pWTIkv8R1fXOknCshD kGqnHNh3c0z3Ki3l4qYcoBiFn/hh9sT9yeVqGUGSl9FD4fVBO3gCuhTg1YUG5hpdNuDZJOTbl 0J+ZJe60YKOY7WstuNxLcPrlOB0XTHKbrkUvUg2JCILxfXUcb1h1OOVt8AMxb6WUFXZH3LMUb J+whzdYtf3Zfv5i9d4OPIKR51Bxo6PXPKwtt89ArRnpPZZUOLyrtxWAu6iTJoy75dywtPEuru oOIUZKmnL7Vdwre7YfraeyjCNvgEFPNTaYsbr4IIFd/v/CebaFVLHbxvSZwgBaKmmt2vUCMAr 4v0YXKwMpzqb6d3Vvhbmw0dPGqAKT0JI3lhD/xCInn5lZ67K1qM/Fg6N0jA8SkBc0zCdLxbJG 6McTfSn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 24 Aug 2016 19:45:23 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kmalloc_array". Suggested-by: Paolo Bonzini This issue was detected also by using the Coccinelle software. * Replace the specification of data structures by pointer dereferences to make the corresponding size determination a bit safer according to the Linux coding style convention. * Delete the local variable "size" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- v2: Rebased on source files from "Linux next-20160824". Advices were integrated from source code review. arch/s390/kvm/guestdbg.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/arch/s390/kvm/guestdbg.c b/arch/s390/kvm/guestdbg.c index d1f8241..70b71ac 100644 --- a/arch/s390/kvm/guestdbg.c +++ b/arch/s390/kvm/guestdbg.c @@ -206,7 +206,7 @@ static int __import_wp_info(struct kvm_vcpu *vcpu, int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, struct kvm_guest_debug *dbg) { - int ret = 0, nr_wp = 0, nr_bp = 0, i, size; + int ret = 0, nr_wp = 0, nr_bp = 0, i; struct kvm_hw_breakpoint *bp_data = NULL; struct kvm_hw_wp_info_arch *wp_info = NULL; struct kvm_hw_bp_info_arch *bp_info = NULL; @@ -216,14 +216,17 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, else if (dbg->arch.nr_hw_bp > MAX_BP_COUNT) return -EINVAL; - size = dbg->arch.nr_hw_bp * sizeof(struct kvm_hw_breakpoint); - bp_data = kmalloc(size, GFP_KERNEL); + bp_data = kmalloc_array(dbg->arch.nr_hw_bp, + sizeof(*bp_data), + GFP_KERNEL); if (!bp_data) { ret = -ENOMEM; goto error; } - if (copy_from_user(bp_data, dbg->arch.hw_bp, size)) { + if (copy_from_user(bp_data, + dbg->arch.hw_bp, + sizeof(*bp_data) * dbg->arch.nr_hw_bp)) { ret = -EFAULT; goto error; } @@ -241,17 +244,19 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, } } - size = nr_wp * sizeof(struct kvm_hw_wp_info_arch); - if (size > 0) { - wp_info = kmalloc(size, GFP_KERNEL); + if (nr_wp > 0) { + wp_info = kmalloc_array(nr_wp, + sizeof(*wp_info), + GFP_KERNEL); if (!wp_info) { ret = -ENOMEM; goto error; } } - size = nr_bp * sizeof(struct kvm_hw_bp_info_arch); - if (size > 0) { - bp_info = kmalloc(size, GFP_KERNEL); + if (nr_bp > 0) { + bp_info = kmalloc_array(nr_bp, + sizeof(*bp_info), + GFP_KERNEL); if (!bp_info) { ret = -ENOMEM; goto error; -- 2.9.3