From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752655AbcG2IQq (ORCPT ); Fri, 29 Jul 2016 04:16:46 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:53850 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbcG2IQn (ORCPT ); Fri, 29 Jul 2016 04:16:43 -0400 Subject: Re: [PATCH v2 1/4] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy() To: Grygorii Strashko , "David S. Miller" , References: <20160728175037.22053-1-grygorii.strashko@ti.com> <20160728175037.22053-2-grygorii.strashko@ti.com> CC: Sekhar Nori , , From: Mugunthan V N Message-ID: Date: Fri, 29 Jul 2016 13:46:36 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160728175037.22053-2-grygorii.strashko@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 28 July 2016 11:20 PM, Grygorii Strashko wrote: > Fix deadlock in cpdma_ctlr_destroy() which is triggered now on > cpsw module removal: > cpsw_remove() > - cpdma_ctlr_destroy() > - spin_lock_irqsave(&ctlr->lock, flags) > - cpdma_ctlr_stop() > - spin_lock_irqsave(&ctlr->lock, flags); > - cpdma_chan_destroy() > - spin_lock_irqsave(&ctlr->lock, flags); > > The issue has not been observed before because CPDMA channels have > been destroyed manually by CPSW until commit d941ebe88a41 ("net: > ethernet: ti: cpsw: use destroy ctlr to destroy channels") was merged. > > Signed-off-by: Grygorii Strashko Reviewed-by: Mugunthan V N Regards Mugunthan V N