From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F04BDC43464 for ; Fri, 18 Sep 2020 11:57:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B77F62100A for ; Fri, 18 Sep 2020 11:57:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="cIlN5Mow" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726553AbgIRL5Q (ORCPT ); Fri, 18 Sep 2020 07:57:16 -0400 Received: from m42-11.mailgun.net ([69.72.42.11]:28973 "EHLO m42-11.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbgIRL5N (ORCPT ); Fri, 18 Sep 2020 07:57:13 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1600430232; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=azsUpAi2ZxIp5qSiODfJODHqLAc6+8CcBnmxsKDe3eY=; b=cIlN5Mowe6y8ZQGXfGE/g4ujEIWgguFy4h78YlHawF/IrE7JuhwAYvnqJCmg40Om/58hPGGC htQEIbe3P9p3Ga+LCxErPv2MZUhpp8dEYgz6JrAD1t7zQjtmoE8UxRhvxHdLpT0Hxa9XkclD zkYI/1PmeHaVRUkaAy+jZ4qoT5A= X-Mailgun-Sending-Ip: 69.72.42.11 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5f649f4ffda7475cca6c1db5 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 18 Sep 2020 11:51:43 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 22A4DC433FF; Fri, 18 Sep 2020 11:51:43 +0000 (UTC) Received: from [10.131.172.121] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: srivasam) by smtp.codeaurora.org (Postfix) with ESMTPSA id 670A5C433C8; Fri, 18 Sep 2020 11:51:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 670A5C433C8 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=srivasam@codeaurora.org Subject: Re: [PATCH v2] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver To: Doug Anderson Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Rohit kumar , Srinivas Kandagatla , Ajit Pandey , Cheng-Yi Chiang References: <1599019441-29308-1-git-send-email-srivasam@codeaurora.org> From: Srinivasa Rao Mandadapu Organization: Qualcomm India Private Limited Message-ID: Date: Fri, 18 Sep 2020 17:21:37 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Mr. Doug for your time to review this patch!! On 9/14/2020 11:11 PM, Doug Anderson wrote: > Hi, > > On Tue, Sep 1, 2020 at 9:04 PM Srinivasa Rao Mandadapu > wrote: >> From: Ajit Pandey >> >> Add the I2S controller node to sc7180 dtsi. >> Add pinmux for primary and secondary I2S. >> >> Signed-off-by: Ajit Pandey >> Signed-off-by: Cheng-Yi Chiang >> Signed-off-by: Srinivasa Rao Mandadapu >> --- >> >> arch/arm64/boot/dts/qcom/sc7180.dtsi | 69 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 69 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> index d46b383..db60ca5 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> @@ -676,6 +676,36 @@ >> }; >> }; >> >> + lpass_cpu: lpass@62f00000 { >> + compatible = "qcom,sc7180-lpass-cpu"; >> + >> + reg = <0 0x62f00000 0 0x29000>; >> + reg-names = "lpass-lpaif"; >> + >> + iommus = <&apps_smmu 0x1020 0>; >> + >> + power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; >> + >> + clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>, >> + <&lpasscc LPASS_AUDIO_CORE_CORE_CLK>, >> + <&lpasscc LPASS_AUDIO_CORE_EXT_MCLK0_CLK>, >> + <&lpasscc LPASS_AUDIO_CORE_SYSNOC_MPORT_CORE_CLK>, >> + <&lpasscc LPASS_AUDIO_CORE_LPAIF_PRI_IBIT_CLK>, >> + <&lpasscc LPASS_AUDIO_CORE_LPAIF_SEC_IBIT_CLK>; >> + >> + clock-names = "pcnoc-sway-clk", "audio-core", >> + "mclk0", "pcnoc-mport-clk", >> + "mi2s-bit-clk0", "mi2s-bit-clk1"; >> + >> + >> + #sound-dai-cells = <1>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + interrupts = ; >> + interrupt-names = "lpass-irq-lpaif"; >> + }; >> + >> sdhc_1: sdhci@7c4000 { > Your node is still sorted incorrectly. Nodes with unit addresses > should be sorted numerically. > > The number 0x62f00000 is greater than the number 0x7c4000. Thus your > node should not be placed above "sdhci@7c4000". It should be placed > somewhere further down in the file. Will place it accordingly. > > >> compatible = "qcom,sc7180-sdhci", "qcom,sdhci-msm-v5"; >> reg = <0 0x7c4000 0 0x1000>, >> @@ -1721,6 +1751,45 @@ >> }; >> }; >> >> + sec_mi2s_active: sec-mi2s-active { >> + pinmux { >> + pins = "gpio49", "gpio50", "gpio51"; >> + function = "mi2s_1"; >> + }; >> + >> + pinconf { >> + pins = "gpio49", "gpio50", "gpio51";; > nit: double-semi-colon. -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.