From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752832AbdCWHaW (ORCPT ); Thu, 23 Mar 2017 03:30:22 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:57083 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752774AbdCWHaF (ORCPT ); Thu, 23 Mar 2017 03:30:05 -0400 Subject: Re: [EXT] Re: [PATCH v6 07/14] dt: bindings: Add bindings for Marvell Xenon SD Host Controller To: Ulf Hansson , Gregory CLEMENT References: <3a4ce2fd25ed812482b0fc96f50dd305c8f40fe9.1487091464.git-series.gregory.clement@free-electrons.com> CC: Adrian Hunter , "linux-mmc@vger.kernel.org" , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , "linux-arm-kernel@lists.infradead.org" , Mike Turquette , Stephen Boyd , linux-clk , "linux-kernel@vger.kernel.org" , Rob Herring , "devicetree@vger.kernel.org" , Jimmy Xu , Jisheng Zhang , Nadav Haklai , Ryan Gao , Doug Jones , Victor Gu , "Wei(SOCP) Liu" , Wilson Ding , Yehuda Yitschak , Marcin Wojtas , Hanna Hawa , Kostya Porotchkin From: Ziji Hu Message-ID: Date: Thu, 23 Mar 2017 13:32:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-23_05:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703230052 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ulf, On 2017/3/15 20:48, Ulf Hansson wrote: > [...] > >> + >> +Example: >> +- For eMMC: >> + >> + sdhci@aa0000 { >> + compatible = "marvell,armada-ap806-sdhci"; >> + reg = <0xaa0000 0x1000>; >> + interrupts = >> + clocks = <&emmc_clk>; >> + clock-names = "core"; >> + bus-width = <4>; >> + marvell,xenon-phy-slow-mode; >> + marvell,xenon-tun-count = <11>; > > There's no vmmc-supply here. > > How do you control power to the eMMC card? > Sorry for the delayed reply. Just confirmed with the engineers. It seems that there is a regulator. I will ask for a complete node example. >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + apm_mmccard: mmccard@0 { >> + compatible = "mmc-card"; >> + reg = <0>; >> + }; >> + }; >> + >> +- For SD/SDIO: >> + >> + sdhci@ab0000 { >> + compatible = "marvell,armada-cp110-sdhci"; >> + reg = <0xab0000 0x1000>; >> + interrupts = >> + vqmmc-supply = <&sd_regulator>; > > I guess you know vqmmc is for the I/O voltage. > > Again, how do you power the SD/SDIO card? No vmmc? The vmmc-supply regulator does exist according to the engineer. I will ask them to provide a complete one. > >> + clocks = <&sdclk>; >> + clock-names = "core"; >> + bus-width = <4>; >> + marvell,xenon-tun-count = <9>; >> + }; >> + >> +- For eMMC with compatible "marvell,armada-3700-sdhci": >> + >> + sdhci@aa0000 { >> + compatible = "marvell,armada-3700-sdhci"; >> + reg = <0xaa0000 0x1000>, >> + ; >> + interrupts = >> + clocks = <&emmcclk>; >> + clock-names = "core"; >> + bus-width = <8>; >> + mmc-ddr-1_8v; >> + mmc-hs400-1_8v; > > Again, no vmmc? > The engineer told me the power to eMMC card is fixed on this platform. They don't implement a specific regulator for eMMC core power. >> + >> + marvell,pad-type = "fixed-1-8v"; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + mmccard: mmccard@0 { >> + compatible = "mmc-card"; >> + reg = <0>; >> + }; >> + }; >> + >> +- For SD/SDIO with compatible "marvell,armada-3700-sdhci": >> + >> + sdhci@ab0000 { >> + compatible = "marvell,armada-3700-sdhci"; >> + reg = <0xab0000 0x1000>, >> + ; >> + interrupts = >> + vqmmc-supply = <&sd_regulator>; > > Again, no vmmc? > It seems that the core power to SD is also fixed. >> + clocks = <&sdclk>; >> + clock-names = "core"; >> + bus-width = <4>; >> + >> + marvell,pad-type = "sd"; >> + }; >> -- >> git-series 0.9.1 > > > Kind regards > Uffe >