From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751310AbdFFHQB (ORCPT ); Tue, 6 Jun 2017 03:16:01 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33085 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbdFFHP7 (ORCPT ); Tue, 6 Jun 2017 03:15:59 -0400 Subject: Re: [PATCH v4 5/8] nvme: get list of namespace descriptors To: Christoph Hellwig , Johannes Thumshirn Cc: Keith Busch , Hannes Reinecke , maxg@mellanox.com, Linux NVMe Mailinglist , Linux Kernel Mailinglist References: <20170604103649.22130-1-jthumshirn@suse.de> <20170604103649.22130-6-jthumshirn@suse.de> <20170605053825.GE19480@lst.de> From: Sagi Grimberg Message-ID: Date: Tue, 6 Jun 2017 10:15:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170605053825.GE19480@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/17 08:38, Christoph Hellwig wrote: >> + } >> + len = NVME_NIDT_UUID_LEN; >> + memcpy(ns->uuid, data + pos + sizeof(*cur), len); >> + break; >> + default: >> + dev_warn(ns->ctrl->dev, >> + "Invalid Namespace Identification Descriptor Type: %d\n", >> + cur->nidt); >> + return; > > Please drop the warning and return, the spec says hosts should ignore > unknown types. This is important to future proof for new types that > could be added. Also, please stay consistent with the rest of the driver by logging the correct device prefix using ctrl->device and not ctrl->dev. (if we have some ctrl->dev left-overs, can you also send a patch to fix?)