From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Yue Hu <zbestahu@gmail.com>
Cc: rui.zhang@intel.com, amit.kucheria@verdurent.com,
viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, huyue2@yulong.com,
zbestahu@163.com
Subject: Re: [PATCH] thermal: sysfs: fall back to vzalloc for cooling device's statistics
Date: Wed, 26 Aug 2020 11:19:02 +0200 [thread overview]
Message-ID: <c3fd7949-b33a-aca3-8dd5-1c2df35fb63d@linaro.org> (raw)
In-Reply-To: <20200826101319.00003048.zbestahu@gmail.com>
Hi Yue,
On 26/08/2020 04:13, Yue Hu wrote:
> On Mon, 24 Aug 2020 12:40:35 +0200
> Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
>> On 18/08/2020 08:30, Yue Hu wrote:
>>> From: Yue Hu <huyue2@yulong.com>
>>>
>>> We observed warning about kzalloc() when register thermal cooling device
>>> in backlight_device_register(). backlight display can be a cooling device
>>> since reducing screen brightness will can help reduce temperature.
>>>
>>> However, ->get_max_state of backlight will assign max brightness of 1024
>>> to states. The memory size can be getting 1MB+ due to states * states.
>>
>> What are the benefits of a 1024 states cooling device ? Is the
>> difference noticeable with a such small step ?
>
> Okay, this issue is happened under MSM/Android platform. QCOM spmi wled driver
> will define the max brightness. We needs to fix the issue to get thermal statistics.
Let me rephrase my questions:
Don't you think there is something wrong in creating a 1024 x 1024
matrix to show transitions ?
What is the benefit of such stats ?
What is the benefit of having a 1024 states cooling device ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-08-26 9:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 6:30 [PATCH] thermal: sysfs: fall back to vzalloc for cooling device's statistics Yue Hu
2020-08-19 11:05 ` Amit Kucheria
2020-08-19 11:17 ` Amit Kucheria
2020-08-20 2:57 ` Yue Hu
2020-08-24 10:40 ` Daniel Lezcano
2020-08-26 2:13 ` Yue Hu
2020-08-26 9:19 ` Daniel Lezcano [this message]
2020-08-27 4:03 ` Yue Hu
2020-08-27 5:14 ` Viresh Kumar
2020-08-27 6:20 ` Yue Hu
2020-08-27 6:26 ` Viresh Kumar
2020-08-27 6:40 ` Yue Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3fd7949-b33a-aca3-8dd5-1c2df35fb63d@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=huyue2@yulong.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=zbestahu@163.com \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).