* [PATCH] agp: remove set but not used variable 'current_size'
@ 2021-05-14 6:22 Yu Kuai
2021-05-29 9:05 ` yukuai (C)
0 siblings, 1 reply; 3+ messages in thread
From: Yu Kuai @ 2021-05-14 6:22 UTC (permalink / raw)
To: airlied; +Cc: linux-kernel, yukuai3, yi.zhang
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/char/agp/via-agp.c:131:28: warning: variable ‘current_size’
set but not used [-Wunused-but-set-variable]
It is never used, and so can be removed.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
drivers/char/agp/via-agp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/char/agp/via-agp.c b/drivers/char/agp/via-agp.c
index 87a92a044570..dc594f4eca38 100644
--- a/drivers/char/agp/via-agp.c
+++ b/drivers/char/agp/via-agp.c
@@ -128,9 +128,6 @@ static int via_fetch_size_agp3(void)
static int via_configure_agp3(void)
{
u32 temp;
- struct aper_size_info_16 *current_size;
-
- current_size = A_SIZE_16(agp_bridge->current_size);
/* address to map to */
agp_bridge->gart_bus_addr = pci_bus_address(agp_bridge->dev,
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] agp: remove set but not used variable 'current_size'
2021-05-14 6:22 [PATCH] agp: remove set but not used variable 'current_size' Yu Kuai
@ 2021-05-29 9:05 ` yukuai (C)
2021-06-07 9:11 ` yukuai (C)
0 siblings, 1 reply; 3+ messages in thread
From: yukuai (C) @ 2021-05-29 9:05 UTC (permalink / raw)
To: airlied; +Cc: linux-kernel, yi.zhang
ping...
On 2021/05/14 14:22, Yu Kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/char/agp/via-agp.c:131:28: warning: variable ‘current_size’
> set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> drivers/char/agp/via-agp.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/char/agp/via-agp.c b/drivers/char/agp/via-agp.c
> index 87a92a044570..dc594f4eca38 100644
> --- a/drivers/char/agp/via-agp.c
> +++ b/drivers/char/agp/via-agp.c
> @@ -128,9 +128,6 @@ static int via_fetch_size_agp3(void)
> static int via_configure_agp3(void)
> {
> u32 temp;
> - struct aper_size_info_16 *current_size;
> -
> - current_size = A_SIZE_16(agp_bridge->current_size);
>
> /* address to map to */
> agp_bridge->gart_bus_addr = pci_bus_address(agp_bridge->dev,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] agp: remove set but not used variable 'current_size'
2021-05-29 9:05 ` yukuai (C)
@ 2021-06-07 9:11 ` yukuai (C)
0 siblings, 0 replies; 3+ messages in thread
From: yukuai (C) @ 2021-06-07 9:11 UTC (permalink / raw)
To: airlied; +Cc: linux-kernel, yi.zhang
ping ...
On 2021/05/29 17:05, yukuai (C) wrote:
> ping...
>
> On 2021/05/14 14:22, Yu Kuai wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/char/agp/via-agp.c:131:28: warning: variable ‘current_size’
>> set but not used [-Wunused-but-set-variable]
>>
>> It is never used, and so can be removed.
>>
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>> ---
>> drivers/char/agp/via-agp.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/char/agp/via-agp.c b/drivers/char/agp/via-agp.c
>> index 87a92a044570..dc594f4eca38 100644
>> --- a/drivers/char/agp/via-agp.c
>> +++ b/drivers/char/agp/via-agp.c
>> @@ -128,9 +128,6 @@ static int via_fetch_size_agp3(void)
>> static int via_configure_agp3(void)
>> {
>> u32 temp;
>> - struct aper_size_info_16 *current_size;
>> -
>> - current_size = A_SIZE_16(agp_bridge->current_size);
>> /* address to map to */
>> agp_bridge->gart_bus_addr = pci_bus_address(agp_bridge->dev,
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-07 9:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 6:22 [PATCH] agp: remove set but not used variable 'current_size' Yu Kuai
2021-05-29 9:05 ` yukuai (C)
2021-06-07 9:11 ` yukuai (C)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).