From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D25F7C433EF for ; Tue, 15 Mar 2022 14:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349253AbiCOOk1 (ORCPT ); Tue, 15 Mar 2022 10:40:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244030AbiCOOkZ (ORCPT ); Tue, 15 Mar 2022 10:40:25 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90A08554B9; Tue, 15 Mar 2022 07:39:13 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 9773E1F44380 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1647355152; bh=+uXxnDg10Cf+ufXL862eCjkJ4f88NJ/VQyoGpWcd7Qs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Y36doFKf4npPYWCd9y3nFrv1m4lo956dMyubnypYTjdWhPwrF4U7Mheu5Ig/7FYeS qwGI/sxoSpGD6NaPBiGBm7ZlLc1CGLl0/AdPYIZNrRCCkXdVrdvQTM8m63CmUDW6Xw A9rtJ1fVca+A/VCFehFtJHuD4wOFpWBcYPXzw6d0GoP50jiSYEBe0kSrbSAayYr/0F ZNnrPfdWFLqWzlEQSXmrE5Kglrol3lebiHpMMllda0Cl0szEptUyphr+x4tUdPZ0DR 3zTXbtIOnMQ7VteODe1hpb+b5RlrnImlB/2iYNzm7oRe9tmLwLP8DQSHh4FZGfaaA3 /HsfSKGZCtzgQ== Message-ID: Date: Tue, 15 Mar 2022 15:39:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v3 16/21] arm64: dts: mt8192: Add vcodec lat and core nodes Content-Language: en-US To: Allen-KH Cheng , Matthias Brugger , Rob Herring , Krzysztof Kozlowski Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai , Ryder Lee , Hui Liu References: <20220304130809.12924-1-allen-kh.cheng@mediatek.com> <20220304130809.12924-17-allen-kh.cheng@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220304130809.12924-17-allen-kh.cheng@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 04/03/22 14:08, Allen-KH Cheng ha scritto: > Add vcodec lat and core nodes for mt8192 SoC. > > Signed-off-by: Allen-KH Cheng > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 58 ++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index ac69033737bb..5fd1fed354d0 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -1285,6 +1285,64 @@ > power-domains = <&spm MT8192_POWER_DOMAIN_ISP2>; > }; > > + vcodec_dec: vcodec-dec@16000000 { > + compatible = "mediatek,mt8192-vcodec-dec"; > + reg = <0 0x16000000 0 0x1000>; /* VDEC_SYS */ > + mediatek,scp = <&scp>; > + iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>; Hello Allen-KH, please, use ranges whenever possible. Example: ranges = <0 0 0 0x16000000 0 0x26000>; vcodec-lat@1000 { reg = <0 0x1000 0 0x800>; ....... }; vcodec-core@25000 { reg = <0 0x25000 0 0x1000>; ....... }; Thanks, Angelo