linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@mellanox.com>
To: "hslester96@gmail.com" <hslester96@gmail.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"siva.kallam@broadcom.com" <siva.kallam@broadcom.com>,
	"prashant@broadcom.com" <prashant@broadcom.com>,
	"michael.chan@broadcom.com" <michael.chan@broadcom.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"GR-Linux-NIC-Dev@marvell.com" <GR-Linux-NIC-Dev@marvell.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"rmody@marvell.com" <rmody@marvell.com>
Subject: Re: [PATCH] net: broadcom: Use dev_get_drvdata
Date: Tue, 23 Jul 2019 18:09:40 +0000	[thread overview]
Message-ID: <c4829e63a48cee1678ee46ea864135569cb9e72c.camel@mellanox.com> (raw)
In-Reply-To: <20190723131929.31987-1-hslester96@gmail.com>

On Tue, 2019-07-23 at 21:19 +0800, Chuhong Yuan wrote:
> Instead of using to_pci_dev + pci_get_drvdata,
> use dev_get_drvdata to make code simpler.
> 

Hi Chuhong, i see that you have generated many stand alone patches that
belong to the same series/patchset.

A better way to do this is to generate one patchset that includes all
the patches and attach a cover letter for it:

$ git format-patch -s --cover-letter --subject-prefix="PATCH net-next"
-o ./patchset/ ${BASE_COMMIT}..${HEAD_COMMIT}

and resubmit with the edited cover-letter.

> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2.c      | 6 ++----
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 ++----
>  drivers/net/ethernet/broadcom/tg3.c       | 6 ++----
>  3 files changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2.c
> b/drivers/net/ethernet/broadcom/bnx2.c
> index dfdd14eadd57..fbc196b480b6 100644
> --- a/drivers/net/ethernet/broadcom/bnx2.c
> +++ b/drivers/net/ethernet/broadcom/bnx2.c
> @@ -8673,8 +8673,7 @@ bnx2_remove_one(struct pci_dev *pdev)
>  static int
>  bnx2_suspend(struct device *device)
>  {
> -	struct pci_dev *pdev = to_pci_dev(device);
> -	struct net_device *dev = pci_get_drvdata(pdev);
> +	struct net_device *dev = dev_get_drvdata(device);
>  	struct bnx2 *bp = netdev_priv(dev);
>  
>  	if (netif_running(dev)) {
> @@ -8693,8 +8692,7 @@ bnx2_suspend(struct device *device)
>  static int
>  bnx2_resume(struct device *device)
>  {
> -	struct pci_dev *pdev = to_pci_dev(device);
> -	struct net_device *dev = pci_get_drvdata(pdev);
> +	struct net_device *dev = dev_get_drvdata(device);
>  	struct bnx2 *bp = netdev_priv(dev);
>  
>  	if (!netif_running(dev))
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 7134d2c3eb1c..1aad59b8a413 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -10920,8 +10920,7 @@ static void bnxt_shutdown(struct pci_dev
> *pdev)
>  #ifdef CONFIG_PM_SLEEP
>  static int bnxt_suspend(struct device *device)
>  {
> -	struct pci_dev *pdev = to_pci_dev(device);
> -	struct net_device *dev = pci_get_drvdata(pdev);
> +	struct net_device *dev = dev_get_drvdata(device);
>  	struct bnxt *bp = netdev_priv(dev);
>  	int rc = 0;
>  
> @@ -10937,8 +10936,7 @@ static int bnxt_suspend(struct device
> *device)
>  
>  static int bnxt_resume(struct device *device)
>  {
> -	struct pci_dev *pdev = to_pci_dev(device);
> -	struct net_device *dev = pci_get_drvdata(pdev);
> +	struct net_device *dev = dev_get_drvdata(device);
>  	struct bnxt *bp = netdev_priv(dev);
>  	int rc = 0;
>  
> diff --git a/drivers/net/ethernet/broadcom/tg3.c
> b/drivers/net/ethernet/broadcom/tg3.c
> index 4c404d2213f9..77f3511b97de 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -18041,8 +18041,7 @@ static void tg3_remove_one(struct pci_dev
> *pdev)
>  #ifdef CONFIG_PM_SLEEP
>  static int tg3_suspend(struct device *device)
>  {
> -	struct pci_dev *pdev = to_pci_dev(device);
> -	struct net_device *dev = pci_get_drvdata(pdev);
> +	struct net_device *dev = dev_get_drvdata(device);
>  	struct tg3 *tp = netdev_priv(dev);
>  	int err = 0;
>  
> @@ -18098,8 +18097,7 @@ static int tg3_suspend(struct device *device)
>  
>  static int tg3_resume(struct device *device)
>  {
> -	struct pci_dev *pdev = to_pci_dev(device);
> -	struct net_device *dev = pci_get_drvdata(pdev);
> +	struct net_device *dev = dev_get_drvdata(device);
>  	struct tg3 *tp = netdev_priv(dev);
>  	int err = 0;
>  

  reply	other threads:[~2019-07-23 18:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 13:19 [PATCH] net: broadcom: Use dev_get_drvdata Chuhong Yuan
2019-07-23 18:09 ` Saeed Mahameed [this message]
2019-07-23 20:03 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4829e63a48cee1678ee46ea864135569cb9e72c.camel@mellanox.com \
    --to=saeedm@mellanox.com \
    --cc=GR-Linux-NIC-Dev@marvell.com \
    --cc=davem@davemloft.net \
    --cc=hslester96@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=prashant@broadcom.com \
    --cc=rmody@marvell.com \
    --cc=siva.kallam@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).