From: Jeroen Hofstee <jhofstee@victronenergy.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
Tony Lindgren <tony@atomide.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Koen Kooi" <koen@dominion.thruhere.net>,
"Benoît Cousson" <bcousson@baylibre.com>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: am335x-sancloud-bbe: Fix PHY mode for ethernet
Date: Wed, 9 Oct 2019 10:09:40 +0000 [thread overview]
Message-ID: <c486a797-6305-8a62-8604-aef5e835ae72@victronenergy.com> (raw)
In-Reply-To: <6dbdf76a-5c04-63ef-0676-5b02fd29c456@ti.com>
Hello Grygorri,
On 10/9/19 11:43 AM, Grygorii Strashko wrote:
>
>
>>> Grygorii doesn't suggest to add a fixes tag, just to change the
>>> referenced
>>> commit to another. Obviously I would like to understand why another
>>> commit
>>> should be referenced. And then I should read and parse the response,
>>> so there
>>> is no special reason, just time...
>>
>> OK sure. Well once you guys have the commit figured out, let me
>> know what to apply. And we know Grygorii is mostly right based
>> on his history of comments so best to not ignore that :)
>
> Sry, but I do not think my request is somehow special.
> Yes, your patch is correct by itself, but commit description is not:
> 1) commit cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for
> RGMII mode") which you've mentioned is A BUG
> and should not be merged first of all (which you can find out by
> reading corresponding thread).
>
> just try checkout that commit and apply your patch on top - networking
> should not work.
>
> But it was merged and not reverted - instead two more patches were
> applied to fix regression.
>
> 2) Those commits are defined final behavior (which i again explained
> above) and that new behavior hardly can
> be called "the bug in the at803x driver" as, unfortunately, there were
> no common conclusion how default values for
> RX/TX delay should be handled vs phy-mode = "rgmii-txid"/"rgmii-rxid".
> Originally many PHY driver kept them default (as per boot
> strapping/bootloader configuration), but now
> some driver (including at803x) started disabling RX delay if
> "rgmii-txid" or TX delay if "rgmii-rxid".
>
> Hence, pls update commit message and add proper fixes tag. smth like:
> "Now after commit 6d4cd041f0af net: phy: at803x: disable delay only
> for RGMII mode the driver will forcibly disable
> RGMII RX delay if phy-mode = "rgmii-txid" is specified in DT which
> will break networking on ..
>
> Hence change .. to ensure ...
> Fixes: "
>
>
Yes, that part is clear to me, and I am not saying you are incorrect,
only that I would like to understand why above commit pops up
(since it makes no sense to me as well, my own commit). And the reason
is rather silly, I guess... I fixed it on master, thereafter checked the
5.1 branch,
while keeping the fixed dtb... :(
Let me check that and I will send a v2. Likely tomorrow
(I am not near the device at the moment).
Regards,
Jeroen
prev parent reply other threads:[~2019-10-09 10:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 9:54 [PATCH] ARM: dts: am335x-sancloud-bbe: Fix PHY mode for ethernet Jeroen Hofstee
2019-10-02 14:48 ` Grygorii Strashko
2019-10-03 8:16 ` Jeroen Hofstee
2019-10-03 9:31 ` Grygorii Strashko
2019-10-08 14:23 ` Tony Lindgren
2019-10-08 14:46 ` Jeroen Hofstee
2019-10-08 16:02 ` Jeroen Hofstee
2019-10-08 16:14 ` Tony Lindgren
2019-10-08 16:42 ` Jeroen Hofstee
2019-10-08 16:51 ` Tony Lindgren
2019-10-08 16:59 ` Jeroen Hofstee
2019-10-08 17:02 ` Tony Lindgren
2019-10-09 9:43 ` Grygorii Strashko
2019-10-09 10:09 ` Jeroen Hofstee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c486a797-6305-8a62-8604-aef5e835ae72@victronenergy.com \
--to=jhofstee@victronenergy.com \
--cc=bcousson@baylibre.com \
--cc=grygorii.strashko@ti.com \
--cc=koen@dominion.thruhere.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).