From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE6E8C19F2A for ; Thu, 28 Jul 2022 07:46:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234770AbiG1Hqt (ORCPT ); Thu, 28 Jul 2022 03:46:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234516AbiG1Hqq (ORCPT ); Thu, 28 Jul 2022 03:46:46 -0400 Received: from smtp98.ord1d.emailsrvr.com (smtp98.ord1d.emailsrvr.com [184.106.54.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 817EF6113F for ; Thu, 28 Jul 2022 00:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=openvpn.net; s=20170822-45nk5nwl; t=1658994027; bh=Ll3lGOHj0SIoQtOcdzdr6ctTpQ/ZQPVtYA+Y55SrikI=; h=Date:Subject:To:From:From; b=Z+RYzJuxAeKcyyVCRG3+2jFgDavsQBuV36JsLrJ1tPe6u6BeRqO7P0IcZ69LFe9vV lGgfrW8ycInrKG6wT9NRcN/Sc9JEvBC82riV6ifFmXWMWd5utc79AuQ2qMWarTnMqq NNCmN9WnTCLd0BWqeYZfBlQN5Qjegc+XwMF76YSk= X-Auth-ID: antonio@openvpn.net Received: by smtp5.relay.ord1d.emailsrvr.com (Authenticated sender: antonio-AT-openvpn.net) with ESMTPSA id B74C6A00C2; Thu, 28 Jul 2022 03:40:26 -0400 (EDT) Message-ID: Date: Thu, 28 Jul 2022 09:41:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RFC 1/1] net: introduce OpenVPN Data Channel Offload (ovpn-dco) Content-Language: en-US To: Andrew Lunn Cc: netdev@vger.kernel.org, David Miller , Jakub Kicinski , linux-kernel@vger.kernel.org References: <20220719014704.21346-1-antonio@openvpn.net> <20220719014704.21346-2-antonio@openvpn.net> From: Antonio Quartulli Organization: OpenVPN Inc. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Classification-ID: 82aa384a-5660-44d4-8ad5-96a212e0778c-1-1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 19/07/2022 17:25, Andrew Lunn wrote: >> +static void ovpn_get_drvinfo(struct net_device *dev, >> + struct ethtool_drvinfo *info) >> +{ >> + strscpy(info->driver, DRV_NAME, sizeof(info->driver)); >> + strscpy(info->version, DRV_VERSION, sizeof(info->version)); >> + strscpy(info->bus_info, "ovpn", sizeof(info->bus_info)); > > version is generally considered useless information if it comes from > the driver. You have no idea if this is version 42 in net-next, or > some backported version in an enterprise kernel with lots of out of > tree patches. The driver is not standalone, it runs inside the > kernel. So in order to understand a bug report, you need to know what > kernel it is. If you don't fill in version, the core will with the > kernel version, which is much more useful. True. However, I guess I will still fill MODULE_VERSION() with a custom string. This may also be useful when building the module out-of-tree. Thanks for the hint! Regards, -- Antonio Quartulli OpenVPN Inc.