From: Daniel Borkmann <daniel@iogearbox.net>
To: Song Liu <liu.song.a23@gmail.com>, Arnd Bergmann <arnd@arndb.de>
Cc: Alexei Starovoitov <ast@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
John Fastabend <john.fastabend@gmail.com>,
Martin KaFai Lau <kafai@fb.com>,
makita.toshiaki@lab.ntt.co.jp, Lawrence Brakmo <brakmo@fb.com>,
Andrey Ignatov <rdna@fb.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Mathieu Xhonneux <m.xhonneux@gmail.com>,
dsahern@gmail.com, Networking <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bpf: fix building without CONFIG_INET
Date: Fri, 5 Oct 2018 21:07:21 +0200 [thread overview]
Message-ID: <c4b5f1af-075a-4166-4108-81acda663970@iogearbox.net> (raw)
In-Reply-To: <CAPhsuW7pg9Wp5am3Kc1t3UoAG1=EYzUeq8E2k7Pmv8yGu9JaEQ@mail.gmail.com>
On 10/05/2018 09:02 PM, Song Liu wrote:
[...]
> BPF_CALL_x() has static already (before this patch). We should not
> need change that
> for all the BPF_CALL_?(). Joe's version looks better to me.
My preference as well, thanks!
next prev parent reply other threads:[~2018-10-05 19:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 16:15 [PATCH] bpf: fix building without CONFIG_INET Arnd Bergmann
2018-10-05 17:19 ` Joe Stringer
2018-10-05 19:02 ` Song Liu
2018-10-05 19:07 ` Daniel Borkmann [this message]
2018-10-08 8:40 ` Daniel Borkmann
2018-10-08 18:24 ` Joe Stringer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4b5f1af-075a-4166-4108-81acda663970@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=brakmo@fb.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liu.song.a23@gmail.com \
--cc=m.xhonneux@gmail.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=rdna@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).