From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92BA8C10F0E for ; Sun, 7 Apr 2019 06:17:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D0F120B1F for ; Sun, 7 Apr 2019 06:17:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="lEPkkgTC"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="lEPkkgTC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726239AbfDGGRX (ORCPT ); Sun, 7 Apr 2019 02:17:23 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59554 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725929AbfDGGRX (ORCPT ); Sun, 7 Apr 2019 02:17:23 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D8EDC60DB4; Sun, 7 Apr 2019 06:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554617842; bh=lF5ZZpsM09cy4kzAr7ABnAwV4eIOLHbBq8F9ftKmf0U=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=lEPkkgTCBt2J1cqGdWrZGcSN/0wmBN7omL31Wl3zLfHcCYBuvTjtC+5bOi7gBFQh6 sNeN6366WKwo4hypEpBGfqTyv3fZhI8NTv7Qn+RSPQ52RW6+xLstFQ6Qf4gkxHEA4u AxwJ0eQX65fbhK8s/HhMUF6by92muVeVsZhyR95A= Received: from [10.79.171.6] (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mojha@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A9E1D6044E; Sun, 7 Apr 2019 06:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554617842; bh=lF5ZZpsM09cy4kzAr7ABnAwV4eIOLHbBq8F9ftKmf0U=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=lEPkkgTCBt2J1cqGdWrZGcSN/0wmBN7omL31Wl3zLfHcCYBuvTjtC+5bOi7gBFQh6 sNeN6366WKwo4hypEpBGfqTyv3fZhI8NTv7Qn+RSPQ52RW6+xLstFQ6Qf4gkxHEA4u AxwJ0eQX65fbhK8s/HhMUF6by92muVeVsZhyR95A= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A9E1D6044E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mojha@codeaurora.org Subject: Re: [PATCH] powerpc/pseries/pmem: fix a set but not used value To: Qian Cai , mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org Cc: oohall@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20190407015447.39292-1-cai@lca.pw> From: Mukesh Ojha Message-ID: Date: Sun, 7 Apr 2019 11:47:10 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190407015447.39292-1-cai@lca.pw> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/7/2019 7:24 AM, Qian Cai wrote: > The commit 4c5d87db4978 ("powerpc/pseries: PAPR persistent memory > support") set a local variable "count" in dlpar_hp_pmem() but never > use it. > > arch/powerpc/platforms/pseries/pmem.c: In function 'dlpar_hp_pmem': > arch/powerpc/platforms/pseries/pmem.c:109:6: warning: variable 'count' > set but not used [-Wunused-but-set-variable] > > Signed-off-by: Qian Cai Reviewed-by: Mukesh Ojha Cheers, -Mukesh > --- > arch/powerpc/platforms/pseries/pmem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/powerpc/platforms/pseries/pmem.c b/arch/powerpc/platforms/pseries/pmem.c > index 27f0a915c8a9..f860a897a9e0 100644 > --- a/arch/powerpc/platforms/pseries/pmem.c > +++ b/arch/powerpc/platforms/pseries/pmem.c > @@ -106,7 +106,7 @@ static ssize_t pmem_drc_remove_node(u32 drc_index) > > int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog) > { > - u32 count, drc_index; > + u32 drc_index; > int rc; > > /* slim chance, but we might get a hotplug event while booting */ > @@ -123,7 +123,6 @@ int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog) > return -EINVAL; > } > > - count = hp_elog->_drc_u.drc_count; > drc_index = hp_elog->_drc_u.drc_index; > > lock_device_hotplug();