From: skakit@codeaurora.org
To: Rob Herring <robh@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
kgunda@codeaurora.org, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Courtney Cavin <courtney.cavin@sonymobile.com>,
Vinod Koul <vkoul@kernel.org>, Sebastian Reichel <sre@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
David Collins <collinsd@codeaurora.org>,
Andy Yan <andy.yan@rock-chips.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, Andy Gross <agross@kernel.org>
Subject: Re: [PATCH V3 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml
Date: Wed, 12 May 2021 10:17:43 +0530 [thread overview]
Message-ID: <c4e286ae6bd621a9d84184d5d014d060@codeaurora.org> (raw)
In-Reply-To: <20210510162445.GA230005@robh.at.kernel.org>
On 2021-05-10 21:54, Rob Herring wrote:
> On Mon, May 10, 2021 at 09:01:39AM -0500, Rob Herring wrote:
>> On Mon, 10 May 2021 12:31:03 +0530, satya priya wrote:
>> > Convert qcom pm8941 power key binding from .txt to .yaml format.
>> >
>> > Signed-off-by: satya priya <skakit@codeaurora.org>
>> > ---
>> > Changes in V2:
>> > - Fixed bot errors, took reference from input.yaml for "linux,code"
>> > - Added one complete example for powerkey and resin, and referenced it
>> > in main PON binding.
>> > - Moved this patch to the end of the series.
>> >
>> > Changes in V3:
>> > - Moved this patch before PON binding patch.
>> > - As per Rob's comments, added allOf at the beginning of binding.
>> > Added maxItems for interrupts.
>> > - Added 'unevaluatedProperties' instead of 'additionalProperties' as
>> > we are using allOf.
>> >
>> > .../bindings/input/qcom,pm8941-pwrkey.txt | 55 --------------
>> > .../bindings/input/qcom,pm8941-pwrkey.yaml | 87 ++++++++++++++++++++++
>> > 2 files changed, 87 insertions(+), 55 deletions(-)
>> > delete mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
>> > create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
>> >
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m
>> dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.example.dt.yaml:0:0:
>> /example-0/spmi@c440000/pmic@0/pon_hlos@1300: failed to match any
>> schema with compatible: ['qcom,pm8998-pon']
>
> You have the same example in patch 5, so drop the example here. That
> will fix this circular dependency.
Earlier I have dropped example from qcom-pon.yaml. Now, I will add the
example there and drop here.
next prev parent reply other threads:[~2021-05-12 4:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 7:00 [PATCH V3 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral satya priya
2021-05-10 7:01 ` [PATCH V3 1/5] input: pm8941-pwrkey: add " satya priya
2021-06-02 4:36 ` Dmitry Torokhov
2021-05-10 7:01 ` [PATCH V3 2/5] dt-bindings: input: pm8941-pwrkey: add pmk8350 compatible strings satya priya
2021-06-02 4:36 ` Dmitry Torokhov
2021-05-10 7:01 ` [PATCH V3 3/5] dt-bindings: power: reset: Change 'additionalProperties' to true satya priya
2021-05-10 16:20 ` Rob Herring
2021-06-04 11:08 ` Sebastian Reichel
2021-05-10 7:01 ` [PATCH V3 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml satya priya
2021-05-10 14:01 ` Rob Herring
2021-05-10 16:24 ` Rob Herring
2021-05-12 4:47 ` skakit [this message]
2021-06-02 4:37 ` Dmitry Torokhov
2021-06-02 10:31 ` skakit
2021-05-10 7:01 ` [PATCH V3 5/5] dt-bindings: power: reset: qcom-pon: Convert qcom PON " satya priya
2021-05-10 16:25 ` Rob Herring
2021-06-04 11:09 ` Sebastian Reichel
2021-06-04 11:42 ` skakit
2021-06-04 11:45 ` skakit
2021-06-04 11:58 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4e286ae6bd621a9d84184d5d014d060@codeaurora.org \
--to=skakit@codeaurora.org \
--cc=agross@kernel.org \
--cc=andy.yan@rock-chips.com \
--cc=bjorn.andersson@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=courtney.cavin@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).