From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753893AbdCHRpe (ORCPT ); Wed, 8 Mar 2017 12:45:34 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:19535 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975AbdCHRpY (ORCPT ); Wed, 8 Mar 2017 12:45:24 -0500 Subject: Re: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t To: "Reshetova, Elena" , "gregkh@linuxfoundation.org" References: <1488810076-3754-1-git-send-email-elena.reshetova@intel.com> <1488810076-3754-30-git-send-email-elena.reshetova@intel.com> <99270126-7751-eed0-5efa-fc695ff3be25@oracle.com> <2236FBA76BA1254E88B949DDB74E612B41C56177@IRSMSX102.ger.corp.intel.com> Cc: "peterz@infradead.org" , "linux-pci@vger.kernel.org" , "target-devel@vger.kernel.org" , "linux1394-devel@lists.sourceforge.net" , "devel@driverdev.osuosl.org" , "linux-s390@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-serial@vger.kernel.org" , "fcoe-devel@open-fcoe.org" , "xen-devel@lists.xenproject.org" , "open-iscsi@googlegroups.com" , "linux-media@vger.kernel.org" , Kees Cook , "linux-raid@vger.kernel.org" , "linux-bcache@vger.kernel.org" , Hans Liljestrand , David Windsor , "netdev@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , Juergen Gross From: Boris Ostrovsky Message-ID: Date: Wed, 8 Mar 2017 12:45:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <2236FBA76BA1254E88B949DDB74E612B41C56177@IRSMSX102.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/2017 08:49 AM, Reshetova, Elena wrote: >> On 03/06/2017 09:21 AM, Elena Reshetova wrote: >>> refcount_t type and corresponding API should be >>> used instead of atomic_t when the variable is used as >>> a reference counter. This allows to avoid accidental >>> refcounter overflows that might lead to use-after-free >>> situations. >>> >>> Signed-off-by: Elena Reshetova >>> Signed-off-by: Hans Liljestrand >>> Signed-off-by: Kees Cook >>> Signed-off-by: David Windsor >>> --- >>> drivers/xen/gntdev.c | 11 ++++++----- >>> 1 file changed, 6 insertions(+), 5 deletions(-) >> Reviewed-by: Boris Ostrovsky > Is there a tree that can take this change? Turns out it is better to propagate changes via separate trees and only leftovers can be taken via Greg's tree. > Sure, we can take it via Xen tree for rc3. -boris