From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 197E7C33CAF for ; Thu, 16 Jan 2020 03:45:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E351F22522 for ; Thu, 16 Jan 2020 03:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730221AbgAPDoz (ORCPT ); Wed, 15 Jan 2020 22:44:55 -0500 Received: from regular1.263xmail.com ([211.150.70.204]:47236 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728905AbgAPDoy (ORCPT ); Wed, 15 Jan 2020 22:44:54 -0500 Received: from localhost (unknown [192.168.167.223]) by regular1.263xmail.com (Postfix) with ESMTP id B32AB25B; Thu, 16 Jan 2020 11:44:46 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 Received: from [172.16.12.9] (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P614T140606315673344S1579146284883989_; Thu, 16 Jan 2020 11:44:45 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: kever.yang@rock-chips.com X-SENDER: yk@rock-chips.com X-LOGIN-NAME: kever.yang@rock-chips.com X-FST-TO: huangtao@rock-chips.com X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2] pinctrl/rockchip: splite soc data to separated driver To: Linus Walleij , Jianqun Xu , =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: David Wu , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , "open list:ARM/Rockchip SoC..." , Peter Robinson , Vagrant Cascadian , afaerber@suse.de, Tao Huang References: <20200109094001.24343-1-jay.xu@rock-chips.com> <20200113011616.19791-1-jay.xu@rock-chips.com> From: Kever Yang Message-ID: Date: Thu, 16 Jan 2020 11:44:44 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/1/15 下午8:51, Linus Walleij wrote: > On Mon, Jan 13, 2020 at 2:16 AM Jianqun Xu wrote: > >> * Decrease codes of pinctrl-rockchip.c from 4,000 lines to 2000 by >> separating soc data to a new file. >> >> * Move rockchip pinctrl related struct definations to a head file. >> >> * Keep legency pinctrl-rockchip.c under driver/pinctrl but not to >> compile it, conveniently for reviewers. >> >> Signed-off-by: Jianqun Xu > This patch looks good, two things are missing: > > - Review from Heiko > > - A change to MAINTAINERS so that the file pattern still > matches > > Should someone from Rockchip also sign up as comaintainer > for this driver by the way? (Though the people at Rockchip > posting patches for this seem to change a bit.) The kernel Image size is keep growing, this patch can help reduce the size of kernel image for one SoC, and this is what we have done in U-Boot mainline. And for distribution kernel who need to cover all the SoCs with one kernel image, need to update the defconfig. The patch looks good to me, Reviewed-by: Kever Yang Thanks, - Kever > > Yours, > Linus Walleij > >