From: Joe Perches <joe@perches.com>
To: Alex Elder <elder@ieee.org>, Greg KH <gregkh@linuxfoundation.org>,
Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
Cc: johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com,
Dwaipayan Ray <dwaipayanray1@gmail.com>
Subject: Re: [PATCH] staging: greybus: Match parentheses alignment
Date: Wed, 14 Apr 2021 09:11:40 -0700 [thread overview]
Message-ID: <c502a48ded02fb681a5978b5af888c74be9625ec.camel@perches.com> (raw)
In-Reply-To: <78c88472-9ed9-bade-407c-23bd557f19bb@ieee.org>
On Wed, 2021-04-14 at 09:35 -0500, Alex Elder wrote:
> On 4/14/21 9:29 AM, Joe Perches wrote:
> > On Wed, 2021-04-14 at 08:17 -0500, Alex Elder wrote:
> > > Perhaps (like the -W options for GCC) there
> > > could be a way to specify in a Makefile which checkpatch
> > > messages are reported/not reported? I don't claim that's
> > > a good suggestion, but if I could optionally indicate
> > > somewhere that "two consecutive blank lines is OK for
> > > Greybus" (one example that comes to mind) I might do so.
> >
> > checkpatch already has --ignore=<list> and --types=<list>
> > for the various classes of messages it emits.
> >
> > see: $ ./scripts/checkpatch.pl --list-types --verbose
> >
> > Dwaipayan Ray (cc'd) is supposedly working on expanding
> > the verbose descriptions of each type.
> >
>
> That's awesome, I wasn't aware of that.
>
> Any suggestions on a standardized way to say "in this
> subtree, please provide these arguments to checkpatch.pl"?
>
> I can probably stick it in a README file or something,
> but is there an existing best practice?
There is no standardized mechanism for this checkpatch use.
Putting something in a staging README is in general a good way for
it to _not_ be read by people doing 'my first kernel patch'.
I still think emitting a message for overly long identifiers could
be a decent checkpatch test.
https://lore.kernel.org/lkml/1518801207.13169.15.camel@perches.com/
prev parent reply other threads:[~2021-04-14 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 12:42 [PATCH] staging: greybus: Match parentheses alignment Zhansaya Bagdauletkyzy
2021-04-06 13:27 ` Greg KH
2021-04-06 17:21 ` Joe Perches
2021-04-14 13:17 ` Alex Elder
2021-04-14 14:29 ` Joe Perches
2021-04-14 14:35 ` Alex Elder
2021-04-14 16:11 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c502a48ded02fb681a5978b5af888c74be9625ec.camel@perches.com \
--to=joe@perches.com \
--cc=dwaipayanray1@gmail.com \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
--cc=zhansayabagdaulet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).