From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752860AbdCMOdR (ORCPT ); Mon, 13 Mar 2017 10:33:17 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:34199 "EHLO mail-io0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752117AbdCMOdJ (ORCPT ); Mon, 13 Mar 2017 10:33:09 -0400 Subject: Re: [PATCH v5] blkcg: allocate struct blkcg_gq outside request queue spinlock To: Tahsin Erdogan References: <20170306200319.GF19696@htj.duckdns.org> <20170309080531.9048-1-tahsin@google.com> Cc: Tejun Heo , linux-block@vger.kernel.org, David Rientjes , linux-kernel@vger.kernel.org From: Jens Axboe Message-ID: Date: Mon, 13 Mar 2017 08:32:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2017 09:35 PM, Tahsin Erdogan wrote: > On Sat, Mar 11, 2017 at 2:52 PM, Jens Axboe wrote: > >> >> Talked to Tejun about this as well, and we both agree that the splitting >> this into separate init/alloc paths would be much cleaner. I can't >> apply the current patch, sorry, it's just too ugly to live. > > Do you mean, you prefer the approach that was taken in v1 patch or > something else? I can no longer find v1 of the patch, just v2 and on. Can you send a link to it? -- Jens Axboe