From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F242C433E0 for ; Fri, 5 Jun 2020 03:14:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 583A920772 for ; Fri, 5 Jun 2020 03:14:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="fI1F/2Sa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726088AbgFEDON (ORCPT ); Thu, 4 Jun 2020 23:14:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbgFEDON (ORCPT ); Thu, 4 Jun 2020 23:14:13 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF02BC08C5C1 for ; Thu, 4 Jun 2020 20:14:12 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id 5so2121354pjd.0 for ; Thu, 04 Jun 2020 20:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6KKE6NK5t9Roonzbio2T7KL2VGRRj3+kmOOOa7VG8/s=; b=fI1F/2Sa266KWRP/4o4oPDAY7hothAQoi9UFJqV6trb/SYEHzkFAolymEWGiiiZBG8 h8O2+6IQ2W7tzG5TmaZMAxinUdqYVgimPqyTK0KxM3A1Xps67siipQVTQbMHkSkUnfPg IIjzkYRRKdgYICncw5jTv/hgTFjB9NVm5/WZeMKGSpK6TO3eYKqEvwayr4maTmw1anit SuGCUe6r9YOFOs9yNnbD/VI5HEeYl6mV7YlilU2FiPIwDX0MLGxSL+iyFxl6rxfHrCp9 xYqT/wEObSkN5A5+5VSU/SwunR6E0dRe+/B2+G3h/HSmmVKmXDLIdTl68YrjPAJIdYwy ceNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6KKE6NK5t9Roonzbio2T7KL2VGRRj3+kmOOOa7VG8/s=; b=pwXUgv0BS2lLV71fQbxLExEaUwy4O5l6B2X7AUJMHqd9Ln21e+6DvJoI+JytENEQXj CYDRaaJrC9hEdRv8IMymcpXfJ4Tngamf6U9TmFWehsh5SERz6ReLHcpROCvN9ruy149C mLGljE74c2ksebZF9pkVoCS6AcbCEC8iN7uTg2owGEze7rvNlK0H72Iv7lfBFB7M4MYK GhPxzuPWFgZ8ip6qO6wkdR9x+724AB1Cif7figoMH9RIPIPmMBO80JiEfcaiMeEMDHDq ahHkHlMQxsSTiurYH9u3NPD/7hde/tOEk7wGnawa5aX+FbG9+PIrIfSO20E30rtpo4lK x53g== X-Gm-Message-State: AOAM532vEGUm9Kxn++jPidRwRgsxojkYfDG9r4rVrZIS5KTosBKJgA8Y UsawMJs7jxY6kgnmmJSG3SqhIfpu50Ks5w== X-Google-Smtp-Source: ABdhPJwVc7r07LTRQdHM5JOUgiO7JxGpa/iZLCMO//6XZc4ZtRE//eys78KGf1TSoqDNWxdX4SB7KQ== X-Received: by 2002:a17:902:9a03:: with SMTP id v3mr7842163plp.6.1591326851673; Thu, 04 Jun 2020 20:14:11 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id 124sm5682949pfb.15.2020.06.04.20.14.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2020 20:14:10 -0700 (PDT) Subject: Re: [PATCH] loop: Fix wrong masking of status flags To: Martijn Coenen , hch@lst.de, naresh.kamboju@linaro.org Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200604202520.66459-1-maco@android.com> From: Jens Axboe Message-ID: Date: Thu, 4 Jun 2020 21:14:09 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200604202520.66459-1-maco@android.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/4/20 2:25 PM, Martijn Coenen wrote: > In faf1d25440d6, loop_set_status() now assigns lo_status directly from > the passed in lo_flags, but then fixes it up by masking out flags that > can't be set by LOOP_SET_STATUS; unfortunately the mask was negated. > > Re-ran all ltp ioctl_loop tests, and they all passed. > > Pass run of the previously failing one: > > tst_test.c:1247: INFO: Timeout per run is 0h 05m 00s > tst_device.c:88: INFO: Found free device 0 '/dev/loop0' > ioctl_loop01.c:49: PASS: /sys/block/loop0/loop/partscan = 0 > ioctl_loop01.c:50: PASS: /sys/block/loop0/loop/autoclear = 0 > ioctl_loop01.c:51: PASS: /sys/block/loop0/loop/backing_file = > '/tmp/ZRJ6H4/test.img' > ioctl_loop01.c:65: PASS: get expected lo_flag 12 > ioctl_loop01.c:67: PASS: /sys/block/loop0/loop/partscan = 1 > ioctl_loop01.c:68: PASS: /sys/block/loop0/loop/autoclear = 1 > ioctl_loop01.c:77: PASS: access /dev/loop0p1 succeeds > ioctl_loop01.c:83: PASS: access /sys/block/loop0/loop0p1 succeeds > > Summary: > passed 8 > failed 0 > skipped 0 > warnings 0 Applied, thanks. -- Jens Axboe