From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0A7C43141 for ; Fri, 15 Nov 2019 01:25:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 846A620723 for ; Fri, 15 Nov 2019 01:25:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="m1uJxKeH"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="G+RgoiJ6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727486AbfKOBZY (ORCPT ); Thu, 14 Nov 2019 20:25:24 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:36490 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726956AbfKOBZY (ORCPT ); Thu, 14 Nov 2019 20:25:24 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B46B461162; Fri, 15 Nov 2019 01:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573781123; bh=JdRtZkJ8mhdpbkZNjuHT294B/fO/LejmbNspGfybIec=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m1uJxKeHvTi23WPCBcWrBd49odfWETyuI7t0kaPzC0gwJ4ecvLvElMGHwTcMIGwuV GtdGFNqscYrFXptgWHTxTr64G30lf25YiQ8J98HW0y9plylEkmpp4bUniBOn24OYRY KTO6OfI/dDDtRFiCUlPbfx0gorW8n85ET5Rzyq+o= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 72D2A61016; Fri, 15 Nov 2019 01:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573781122; bh=JdRtZkJ8mhdpbkZNjuHT294B/fO/LejmbNspGfybIec=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G+RgoiJ6wg810RWm+kCImOhVwAIprIQP0JIgp9aGdSLHVOqvIpyjhbR2WSmp5yVkQ sQfuoGwiAxew0643MC63rUWrBD24ik/TVtWXoJQaKuNorL+FYShukwp48HYSHXYt8n G9v05Zqd4Ypv3rJN04j1wWX1v8EUJsQ3IA1tuRJU= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 15 Nov 2019 09:25:22 +0800 From: Can Guo To: Avri Altman Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Andy Gross , Alim Akhtar , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , "open list:ARM/QUALCOMM SUPPORT" , open list Subject: Re: [PATCH v4 2/7] scsi: ufs-qcom: Add reset control support for host controller In-Reply-To: References: <1573627552-12615-1-git-send-email-cang@codeaurora.org> <1573627552-12615-3-git-send-email-cang@codeaurora.org> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-11-14 17:03, Avri Altman wrote: > Hi, > >> >> >> Add reset control for host controller so that host controller can be >> reset as >> required in its power up sequence. >> >> Signed-off-by: Can Guo >> + ret = reset_control_assert(host->core_reset); >> + if (ret) { >> + dev_err(hba->dev, "%s: core_reset assert failed, err = >> %d\n", >> + __func__, ret); >> + goto out; >> + } >> + >> + /* >> + * The hardware requirement for delay between assert/deassert >> + * is at least 3-4 sleep clock (32.7KHz) cycles, which comes >> to >> + * ~125us (4/32768). To be on the safe side add 200us delay. >> + */ >> + usleep_range(200, 210); > Aren't you sleeping anyway in your reset_control_ops? > For our cases, reset_control_assert uses the reset_control_ops->assert() we registered for node &clock_gcc. There is no sleep or delay in Q's reset_control_ops->assert() func. >> + >> + ret = reset_control_deassert(host->core_reset); >> + if (ret) >> + dev_err(hba->dev, "%s: core_reset deassert failed, err >> = %d\n", >> + __func__, ret); >> + >> + usleep_range(1000, 1100); > ditto Same as above. Best Regards, Can Guo.