From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D10AC2D0C3 for ; Mon, 16 Dec 2019 11:35:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D678B206D3 for ; Mon, 16 Dec 2019 11:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727495AbfLPLfB (ORCPT ); Mon, 16 Dec 2019 06:35:01 -0500 Received: from mx2.suse.de ([195.135.220.15]:54246 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727377AbfLPLe6 (ORCPT ); Mon, 16 Dec 2019 06:34:58 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5CED7ACC9; Mon, 16 Dec 2019 11:34:56 +0000 (UTC) Message-ID: Subject: Re: [PATCH 2/9] spi: bcm2835: Release the DMA channel if probe fails after dma_init From: Nicolas Saenz Julienne To: Peter Ujfalusi , broonie@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, shawnguo@kernel.org, s.hauer@pengutronix.de, baohua@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com Cc: vkoul@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Date: Mon, 16 Dec 2019 12:34:54 +0100 In-Reply-To: <20191212135550.4634-3-peter.ujfalusi@ti.com> References: <20191212135550.4634-1-peter.ujfalusi@ti.com> <20191212135550.4634-3-peter.ujfalusi@ti.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-sXE7sJg+XY/TFzJstkte" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-sXE7sJg+XY/TFzJstkte Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2019-12-12 at 15:55 +0200, Peter Ujfalusi wrote: > The DMA channel was not released if either devm_request_irq() or > devm_spi_register_controller() failed. >=20 > Signed-off-by: Peter Ujfalusi > --- Thanks! Reviewed-by: Nicolas Saenz Julienne Regards, Nicolas --=-sXE7sJg+XY/TFzJstkte Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl33a94ACgkQlfZmHno8 x/6CCAf7B+B8hZxRZRMeLVd8ul40vOlcF9rYKCysCJeIolLp9Y2o4IzUDv0K1mel 0z35UloEsK0lerWCQzf9nH6RbxBqfEE5NbQ/N2ewB9/+Ko1YXB/JkhbMx8ApqqoR DFhBiIS9MjrKzpffIY1Wa8f2TRngNKJAGbUVYX2lpW2zhRpqDSaa61WWra+KzbNK vBfmnO3NwN69bN7vqN//ES4MonAbxXm7HGwyI8okIzlwc+rZWympTUBgpwXfGGeC R1OHlJZiexWOW1LID7wjOPAeYbbGEatKio3MBTOAU+Ccx1JTDzjlKx0AtwIqyKTd Oc2YpUm1LThjhmtRyLB1OXGc+8edpw== =JoZp -----END PGP SIGNATURE----- --=-sXE7sJg+XY/TFzJstkte--