From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D33F3C433E0 for ; Tue, 21 Jul 2020 01:17:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFDCC22BF5 for ; Tue, 21 Jul 2020 01:17:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727048AbgGUBRo (ORCPT ); Mon, 20 Jul 2020 21:17:44 -0400 Received: from regular1.263xmail.com ([211.150.70.200]:59770 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbgGUBRo (ORCPT ); Mon, 20 Jul 2020 21:17:44 -0400 Received: from localhost (unknown [192.168.167.32]) by regular1.263xmail.com (Postfix) with ESMTP id 3FE201173; Tue, 21 Jul 2020 09:17:33 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 Received: from [172.16.12.230] (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P4704T139888013862656S1595294251487593_; Tue, 21 Jul 2020 09:17:32 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: andy.yan@rock-chips.com X-SENDER: yxj@rock-chips.com X-LOGIN-NAME: andy.yan@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 X-System-Flag: 0 Subject: =?UTF-8?Q?Re=3a_=5bPATCH_2/5=5d_drm=3a_rockchip=3a_add_missing_regi?= =?UTF-8?B?c3RlcnMgZm9yIFJLMzE4OOOAkOivt+azqOaEj++8jOmCruS7tueUsWxpbnV4LXJv?= =?UTF-8?Q?ckchip-bounces+andy=2eyan=3drock-chips=2ecom=40lists=2einfradead?= =?UTF-8?B?Lm9yZ+S7o+WPkeOAkQ==?= To: Alex Bee , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org References: <20200718200323.3559-1-knaerzche@gmail.com> <20200718200323.3559-3-knaerzche@gmail.com> <871ce1ac-2d5b-c0a2-60a6-6aba0f296c18@rock-chips.com> <12296860-d6ed-5135-7c4e-545362829051@gmail.com> From: Andy Yan Message-ID: Date: Tue, 21 Jul 2020 09:17:31 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <12296860-d6ed-5135-7c4e-545362829051@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alex: On 7/20/20 10:46 PM, Alex Bee wrote: > Hi Andy, > > Am 20.07.20 um 10:22 schrieb Andy Yan: >> Hi Alex: >> >> On 7/19/20 4:03 AM, Alex Bee wrote: >>> This patch adds dither_up, dsp_lut_en, data_blank and dsp_data_swap >>> registers to enable their respective functionality for RK3188's VOP. >>> >>> Signed-off-by: Alex Bee >>> --- >>>   drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 4 ++++ >>>   1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c >>> b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c >>> index b046910129fb..971a6bda7458 100644 >>> --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c >>> +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c >>> @@ -512,6 +512,10 @@ static const struct vop_common rk3188_common = { >>>       .dither_down_en = VOP_REG(RK3188_DSP_CTRL0, 0x1, 11), >>>       .dither_down_mode = VOP_REG(RK3188_DSP_CTRL0, 0x1, 10), >>>       .dsp_blank = VOP_REG(RK3188_DSP_CTRL1, 0x3, 24), >>> +    .dither_up = VOP_REG(RK3188_DSP_CTRL0, 0x1, 9), >>> +    .dsp_lut_en = VOP_REG(RK3188_SYS_CTRL, 0x1, 28), >>> +    .data_blank = VOP_REG(RK3188_DSP_CTRL1, 0x1, 25), >>> +    .dsp_data_swap = VOP_REG(RK3188_DSP_CTRL1, 0x1f, 26), >> >> >> >> I can't find the definition of dsp_data_swap, or I missed something? >> > Note that .dsp_data_swap is not defined with that name in TRM (as it > is not in RK3288/RK3328), since potentially more the one bit would > have to be set for this (currently only RB_SWAP (0x2) is implemented > in the VOP driver). > I mean I didn't find the definition of dsp_data_swap  in struct vop_comm, I even search drm-misc-next tree. > To be some kind of future proof (if BG_SWAP, RG_SWAP, DELTA_SWAP or > DUMMY_SWAP ever get implemented) it should be aligned with what is > defined for RK3288/RK3328 now to automatically benefit from that > additions. And it would, since RK3288_DSP_CTRL0 BIT12, BIT13, BIT14, > BIT15, BIT16 exactly matches with RK3188_DSP_CTRL1 BIT26, BIT27, > BIT28, BIT29, BIT30. > > Current implementation sets BIT13 for RK3288 and with this patch BIT27 > for RK3188 to enable RB_SWAP. > >> >> >>>   }; >>>     static const struct vop_win_data rk3188_vop_win_data[] = { >> >> > Regards, > > Alex > > >