From: Hugues FRUCHET <hugues.fruchet@st.com>
To: Benjamin GAIGNARD <benjamin.gaignard@st.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"valentin.schneider@arm.com" <valentin.schneider@arm.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>
Subject: Re: [PATCH] media: stm32-dcmi: Set minimum cpufreq requirement
Date: Tue, 2 Jun 2020 08:29:36 +0000 [thread overview]
Message-ID: <c53ca6f9-5350-0234-eb52-2c656ffab79c@st.com> (raw)
In-Reply-To: <20200527151613.16083-1-benjamin.gaignard@st.com>
Acked-by: Hugues Fruchet <hugues.fruchet@st.com>
On 5/27/20 5:16 PM, Benjamin Gaignard wrote:
> Before start streaming set cpufreq minimum frequency requirement.
> The cpufreq governor will adapt the frequencies and we will have
> no latency for handling interrupts.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> drivers/media/platform/stm32/stm32-dcmi.c | 29 ++++++++++++++++++++++++++++-
> 1 file changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
> index b8931490b83b..97c342351569 100644
> --- a/drivers/media/platform/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/stm32/stm32-dcmi.c
> @@ -13,6 +13,7 @@
>
> #include <linux/clk.h>
> #include <linux/completion.h>
> +#include <linux/cpufreq.h>
> #include <linux/delay.h>
> #include <linux/dmaengine.h>
> #include <linux/init.h>
> @@ -99,6 +100,8 @@ enum state {
>
> #define OVERRUN_ERROR_THRESHOLD 3
>
> +#define DCMI_MIN_FREQ 650000 /* in KHz */
> +
> struct dcmi_graph_entity {
> struct v4l2_async_subdev asd;
>
> @@ -173,6 +176,10 @@ struct stm32_dcmi {
> struct media_device mdev;
> struct media_pad vid_cap_pad;
> struct media_pipeline pipeline;
> +
> + /* CPU freq contraint */
> + struct cpufreq_policy *policy;
> + struct freq_qos_request qos_req;
> };
>
> static inline struct stm32_dcmi *notifier_to_dcmi(struct v4l2_async_notifier *n)
> @@ -736,11 +743,20 @@ static int dcmi_start_streaming(struct vb2_queue *vq, unsigned int count)
> goto err_release_buffers;
> }
>
> + if (dcmi->policy) {
> + ret = freq_qos_add_request(&dcmi->policy->constraints,
> + &dcmi->qos_req, FREQ_QOS_MIN,
> + DCMI_MIN_FREQ);
> +
> + if (ret < 0)
> + goto err_pm_put;
> + }
> +
> ret = media_pipeline_start(&dcmi->vdev->entity, &dcmi->pipeline);
> if (ret < 0) {
> dev_err(dcmi->dev, "%s: Failed to start streaming, media pipeline start error (%d)\n",
> __func__, ret);
> - goto err_pm_put;
> + goto err_drop_qos;
> }
>
> ret = dcmi_pipeline_start(dcmi);
> @@ -835,6 +851,9 @@ static int dcmi_start_streaming(struct vb2_queue *vq, unsigned int count)
> err_media_pipeline_stop:
> media_pipeline_stop(&dcmi->vdev->entity);
>
> +err_drop_qos:
> + if (dcmi->policy)
> + freq_qos_remove_request(&dcmi->qos_req);
> err_pm_put:
> pm_runtime_put(dcmi->dev);
>
> @@ -863,6 +882,9 @@ static void dcmi_stop_streaming(struct vb2_queue *vq)
>
> media_pipeline_stop(&dcmi->vdev->entity);
>
> + if (dcmi->policy)
> + freq_qos_remove_request(&dcmi->qos_req);
> +
> spin_lock_irq(&dcmi->irqlock);
>
> /* Disable interruptions */
> @@ -2020,6 +2042,8 @@ static int dcmi_probe(struct platform_device *pdev)
> goto err_cleanup;
> }
>
> + dcmi->policy = cpufreq_cpu_get(0);
> +
> dev_info(&pdev->dev, "Probe done\n");
>
> platform_set_drvdata(pdev, dcmi);
> @@ -2049,6 +2073,9 @@ static int dcmi_remove(struct platform_device *pdev)
>
> pm_runtime_disable(&pdev->dev);
>
> + if (dcmi->policy)
> + cpufreq_cpu_put(dcmi->policy);
> +
> v4l2_async_notifier_unregister(&dcmi->notifier);
> v4l2_async_notifier_cleanup(&dcmi->notifier);
> media_entity_cleanup(&dcmi->vdev->entity);
>
next prev parent reply other threads:[~2020-06-02 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 15:16 [PATCH] media: stm32-dcmi: Set minimum cpufreq requirement Benjamin Gaignard
2020-06-02 8:29 ` Hugues FRUCHET [this message]
2020-06-02 9:31 ` Valentin Schneider
2020-06-02 11:37 ` Benjamin GAIGNARD
2020-06-02 13:35 ` Valentin Schneider
2020-06-03 7:34 ` Benjamin GAIGNARD
2020-06-03 7:50 ` Vincent Guittot
2020-06-03 9:41 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c53ca6f9-5350-0234-eb52-2c656ffab79c@st.com \
--to=hugues.fruchet@st.com \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).