From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754757AbeEWQZ7 (ORCPT ); Wed, 23 May 2018 12:25:59 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:32988 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754649AbeEWQZz (ORCPT ); Wed, 23 May 2018 12:25:55 -0400 X-Google-Smtp-Source: AB8JxZpVkj8vCb5zENbN1iU7CAd/CorpjsS/e1fmZnPIrGy5pN6PgG9EDXneTHicSDX/0qw8F9ZlDw== Subject: Re: [PATCH 1/5] Documentation: DT: Add optional 'timeout-sec' property for sp805 To: Robin Murphy , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Mark Rutland , Frank Rowand , Catalin Marinas , Will Deacon Cc: devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org References: <1527014840-21236-1-git-send-email-ray.jui@broadcom.com> <1527014840-21236-2-git-send-email-ray.jui@broadcom.com> From: Ray Jui Message-ID: Date: Wed, 23 May 2018 09:25:49 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/23/2018 3:57 AM, Robin Murphy wrote: > On 22/05/18 19:47, Ray Jui wrote: >> Update the SP805 binding document to add optional 'timeout-sec' >> devicetree property >> >> Signed-off-by: Ray Jui >> Reviewed-by: Scott Branden >> --- >>   Documentation/devicetree/bindings/watchdog/sp805-wdt.txt | 2 ++ >>   1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt >> b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt >> index edc4f0e..f898a86 100644 >> --- a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt >> +++ b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt >> @@ -19,6 +19,8 @@ Required properties: >>   Optional properties: >>   - interrupts : Should specify WDT interrupt number. >> +- timeout-sec : Should specify default WDT timeout in seconds. If >> unset, the >> +                default timeout is 30 seconds > > According to the SP805 TRM, the default interval is dependent on the > rate of WDOGCLK, but would typically be a lot longer than that :/ > > On a related note, anyone have any idea why we seem to have two subtly > different SP805 bindings defined? Interesting, I did not even know that until you pointed this out (and it's funny that I found that I actually reviewed arm,sp805.txt internally in Broadcom code review). It looks like one was done by Bhupesh Sharma (sp805-wdt.txt) and the other was done by Anup Patel (arm,sp805.txt). Both were merged at the same time around March 20, 2016: 915c56bc01d6. I'd assume both were sent out at around the same time. It sounds like we should definitely remove one of them. Given that sp805-wdt.txt appears to have more detailed descriptions on the use of the clocks, should we remove arm,sp805.txt? Thanks, Ray > > Robin. > >>   Examples: >>