From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50984C4646D for ; Fri, 10 Aug 2018 08:33:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0724221B31 for ; Fri, 10 Aug 2018 08:33:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="X4TEZb5i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0724221B31 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727668AbeHJLCf (ORCPT ); Fri, 10 Aug 2018 07:02:35 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36550 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727563AbeHJLCe (ORCPT ); Fri, 10 Aug 2018 07:02:34 -0400 Received: by mail-wm0-f68.google.com with SMTP id w24-v6so1018114wmc.1 for ; Fri, 10 Aug 2018 01:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CAw/f2FK0lcZDxQOxEKHov5c7KMK2uhUZqJcEueyLBo=; b=X4TEZb5iMqsHHBcD06hAqxarmsqV2GEdfsFigtkr99oKd+3xK79eWUoEDCWWwvXIMC IASvQXdk11HH9iz24852bPU5fYJWf5P1NY+Sw/P5XrF6AQOZnYksOA7SPmPGxJg2WUqX XwRQN6y2IRYNMUJXj4NO6wDRMgt5ihFUeKQVs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CAw/f2FK0lcZDxQOxEKHov5c7KMK2uhUZqJcEueyLBo=; b=D9G7Tmqr1tmvUrqNK31+JYyeeZ0fS2GsgXFadJoPPwTY9ZUJ7mLsLFi3cinWkUnRLF SrEZD+TAZSr+BNrCXdYwKfTIXGV6O5weZC/yRgyBr/T17MTeqVtpVETtVjY3Sm3xehxQ YZQLUsR0fFj7zY8ozr01h74+L8YWbShPJZYJnvx+3rcpvgsUMxSSPfWcYuf8ECmdinKX xOB03izcIQZDYPWIekwKlm+qUDdJtS+cI3eL/u1RA+ykwambD5ew1BCGMJk2by0Qz7Kr ma7HPjYqhpirLkllHyvLfZZV/uWZ4ZQ3g9wZBAWVN0V2oia7ahMCAe3giPJtwVuikqsC KzPw== X-Gm-Message-State: AOUpUlEsokIjw3kGkR3vegq93DME2C5RdKl2WQEP99+Z065pCI8CTrh6 ANmRW9Oc2c54eH/Ipl8aIF3row== X-Google-Smtp-Source: AA+uWPzG2Mn+A2oZ+RdO50DuDpbbJLwJVXnBvL807sjlKyy924eTxGZoRt69qd/PwM1pz4TDM/GHIg== X-Received: by 2002:a1c:8f0e:: with SMTP id r14-v6mr912524wmd.79.1533890021185; Fri, 10 Aug 2018 01:33:41 -0700 (PDT) Received: from [192.168.0.18] (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.googlemail.com with ESMTPSA id h5-v6sm10247848wrr.19.2018.08.10.01.33.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Aug 2018 01:33:40 -0700 (PDT) Subject: Re: [PATCH v2 05/29] nvmem: remove the name field from struct nvmem_device To: Bartosz Golaszewski , Jonathan Corbet , Sekhar Nori , Kevin Hilman , Russell King , Arnd Bergmann , Greg Kroah-Hartman , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Grygorii Strashko , "David S . Miller" , Naren , Mauro Carvalho Chehab , Andrew Morton , Lukas Wunner , Dan Carpenter , Florian Fainelli , Ivan Khoronzhuk , Sven Van Asbroeck , Paolo Abeni , Alban Bedel , Rob Herring , David Lechner , Andrew Lunn Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, netdev@vger.kernel.org, Bartosz Golaszewski References: <20180810080526.27207-1-brgl@bgdev.pl> <20180810080526.27207-6-brgl@bgdev.pl> From: Srinivas Kandagatla Message-ID: Date: Fri, 10 Aug 2018 09:33:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180810080526.27207-6-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/18 09:05, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This field is never set and is only used in a single error message. > Remove the field and use nvmem_dev_name() instead. > > Signed-off-by: Bartosz Golaszewski > --- Looks good to me! > drivers/nvmem/core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 31df2e6d6f72..ab3ced2d9a84 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -26,7 +26,6 @@ > #include > > struct nvmem_device { > - const char *name; > struct module *owner; > struct device dev; > int stride; > @@ -712,7 +711,7 @@ static struct nvmem_device *__nvmem_device_get(struct device_node *np, > if (!try_module_get(nvmem->owner)) { > dev_err(&nvmem->dev, > "could not increase module refcount for cell %s\n", > - nvmem->name); > + nvmem_dev_name(nvmem)); > > mutex_lock(&nvmem_mutex); > nvmem->users--; >