linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vignesh Raghavendra <vigneshr@ti.com>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	"open list:SPI NOR SUBSYSTEM" <linux-mtd@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>,
	Sekhar Nori <nsekhar@ti.com>,
	Boris Brezillon <boris.brezillon@collabora.com>
Subject: Re: [PATCH v12 00/14] mtd: spi-nor: add xSPI Octal DTR support
Date: Wed, 16 Sep 2020 11:46:49 +0530	[thread overview]
Message-ID: <c56f3517-383c-2e45-d5cc-fde5a44ac34f@ti.com> (raw)
In-Reply-To: <20200915074727.o4drgfgdabhozjb5@ti.com>



On 9/15/20 1:17 PM, Pratyush Yadav wrote:
> On 15/09/20 12:16PM, Vignesh Raghavendra wrote:
>>
>>
>> On 9/3/20 10:42 PM, Pratyush Yadav wrote:
>>> Hi,
>>>
>>> This series adds support for Octal DTR flashes in the SPI NOR framework,
>>> and then adds hooks for the Cypress Semper and Micron Xcella flashes to
>>> allow running them in Octal DTR mode. This series assumes that the flash
>>> is handed to the kernel in Legacy SPI mode.
>>>
>>> Tested on TI J721E EVM with 1-bit ECC on the Cypress flash.
>>>
>> [...]
>>
>> Please fix checkpatch issues on patch 1, 3, 4 and 5
> 
> I ran checkpatch on my patches based on top of next-20200914 just now. I 
> only see issues with patches 3 and 4. Patches 1 and 5 report no issues. 
> What problems do you see on patches 1 and 5?
> 

Please run with --strict argument to checkpatch. You can see the issues
at: https://pastebin.ubuntu.com/p/5pPWcGNsmp/

> As for patches 3 and 4, the error I see is "ENOTSUPP is not a SUSV4 
> error code, prefer EOPNOTSUPP". I left it in intentionally. There a 
> couple other functions in SPI NOR that use ENOTSUPP instead of 
> EOPNOTSUPP so I followed the local convention.
> 

This is a recent addition to checkpatch: 6b9ea5ff5abd ("checkpatch: warn
about uses of ENOTSUPP").

> If you insist, I can add a preparatory patch that first changes those 
> uses of ENOTSUPP to EOPNOTSUPP and then update patches 3 and 4 to do the 
> same. Let me know.
>  

Changing existing usage of ENOTSUPP to EOPNOTSUPP is a separate exercise
and patches are welcome. But any new addition of ENOTSUPP would need to
be avoided.

Regards
Vignesh

      reply	other threads:[~2020-09-16  6:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 17:12 [PATCH v12 00/14] mtd: spi-nor: add xSPI Octal DTR support Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 01/14] mtd: spi-nor: core: add spi_nor_{read,write}_reg() helpers Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 02/14] mtd: spi-nor: core: add spi_nor_controller_ops_erase helper Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 03/14] mtd: spi-nor: add support for DTR protocol Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 04/14] mtd: spi-nor: sfdp: get command opcode extension type from BFPT Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 05/14] mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 06/14] mtd: spi-nor: core: use dummy cycle and address width info from SFDP Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 07/14] mtd: spi-nor: core: do 2 byte reads for SR and FSR in DTR mode Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 08/14] mtd: spi-nor: core: enable octal DTR mode when possible Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 09/14] mtd: spi-nor: sfdp: detect Soft Reset sequence support from BFPT Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 10/14] mtd: spi-nor: core: perform a Soft Reset on shutdown Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 11/14] mtd: spi-nor: core: disable Octal DTR mode on suspend Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 12/14] mtd: spi-nor: core: expose spi_nor_default_setup() in core.h Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 13/14] mtd: spi-nor: spansion: add support for Cypress Semper flash Pratyush Yadav
2020-09-03 17:13 ` [PATCH v12 14/14] mtd: spi-nor: micron-st: allow using MT35XU512ABA in Octal DTR mode Pratyush Yadav
2020-09-15  6:46 ` [PATCH v12 00/14] mtd: spi-nor: add xSPI Octal DTR support Vignesh Raghavendra
2020-09-15  7:47   ` Pratyush Yadav
2020-09-16  6:16     ` Vignesh Raghavendra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c56f3517-383c-2e45-d5cc-fde5a44ac34f@ti.com \
    --to=vigneshr@ti.com \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=nsekhar@ti.com \
    --cc=p.yadav@ti.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).