From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85992C48BE7 for ; Mon, 8 Jul 2019 09:09:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6210A20665 for ; Mon, 8 Jul 2019 09:09:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729677AbfGHJJy (ORCPT ); Mon, 8 Jul 2019 05:09:54 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:3602 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726284AbfGHJJx (ORCPT ); Mon, 8 Jul 2019 05:09:53 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6897U3M085167 for ; Mon, 8 Jul 2019 05:09:52 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2tkyrjy30d-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 08 Jul 2019 05:09:52 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 8 Jul 2019 10:09:43 +0100 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 8 Jul 2019 10:09:41 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6899SVF29622532 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 8 Jul 2019 09:09:28 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1F17D42042; Mon, 8 Jul 2019 09:09:40 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3487B42045; Mon, 8 Jul 2019 09:09:39 +0000 (GMT) Received: from localhost.localdomain (unknown [9.124.35.94]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 8 Jul 2019 09:09:39 +0000 (GMT) Subject: Re: [RFC 0/2] Optimize the idle CPU search To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, vincent.guittot@linaro.org, subhra.mazumdar@oracle.com References: <20190708045432.18774-1-parth@linux.ibm.com> <20190708080836.GW3402@hirez.programming.kicks-ass.net> From: Parth Shah Date: Mon, 8 Jul 2019 14:39:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20190708080836.GW3402@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19070809-0028-0000-0000-00000381E4DF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19070809-0029-0000-0000-00002441EC52 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-08_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=882 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907080120 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/8/19 1:38 PM, Peter Zijlstra wrote: > On Mon, Jul 08, 2019 at 10:24:30AM +0530, Parth Shah wrote: >> When searching for an idle_sibling, scheduler first iterates to search for >> an idle core and then for an idle CPU. By maintaining the idle CPU mask >> while iterating through idle cores, we can mark non-idle CPUs for which >> idle CPU search would not have to iterate through again. This is especially >> true in a moderately load system >> >> Optimize idle CPUs search by marking already found non idle CPUs during >> idle core search. This reduces iteration count when searching for idle >> CPUs, resulting in lower iteration count. > > Have you seen these patches: > > https://lkml.kernel.org/r/20180530142236.667774973@infradead.org > > I've meant to get back to that, but never quite had the time :/ > Ok, I was not aware of this patch-set. It seems interesting and I will evaluate it. Thanks