From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A46D212E75 for ; Thu, 25 Jan 2024 23:50:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706226649; cv=none; b=VrEBhKhBcQq2qkPmFZs7gKy4naUxDni/IKO7sK/n41ho84O2ToyTwG+YI/CSy19y+YbWQl26qiVq9AFEvvFiC8U8KGoSavvbCS1B1AudwEE/nrab7CA3yozerxg8TogqO0qaBgQC3g2W5gWPiH5mdwyznFb/8677n8UJcq+PLYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706226649; c=relaxed/simple; bh=m477urVRSMnVXboBy6oeu+74ms/xBqBmLsiSC0JOrfo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ujKA1YgWs/OSdxkiMAQo3SQEA8mPG/YQ0u9VOXIblWSlxxZVntdv9tkTdV0NBrZH2/EEdoj+jdmT8ukZtGoC4JOpVNFFu2uEfdCQdL74Qm9MGGFpv4j5yI5MyQ36zjIorvC0n8ZegREBNVpwERCT/81mtkgYzKKVzxGvpAHRscY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rQn3qD5O; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rQn3qD5O" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5100c2f7a16so1316298e87.1 for ; Thu, 25 Jan 2024 15:50:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706226646; x=1706831446; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HMqF6kcGxv/o+d+Qb4jJWsBekLD4OHlxxe3556Hw09Y=; b=rQn3qD5OH3OaKTpt4lt/v/w29U++HO9htvqXyh6zuIeu3A8IImlaOIwdBgm9GK1EY6 xbjdfNZsCtgeod2tyKtG0u2L98WZVsYNkxaBVj7NEJ1upAHsses4/q6grgtugVIog8g1 wduKQauOce2mE4oEncqGpaTsxBh4InKVqwD2fGNtF8rkrXl85ZMOD72LK3mddgUb4Tpv UTuQuI9cbl+AbHrWX7MT5tJo24KXXhFS/S5dwSisXg/tuZPZyvsUG+uGsyi3blZ36rUu W22PN7HmrMLfP0uqZwt+cdUKwSkvqHJwn3oTBa8FHrm+eQFZDIR+3OIesp7zmbnI6bNS T56g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706226646; x=1706831446; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HMqF6kcGxv/o+d+Qb4jJWsBekLD4OHlxxe3556Hw09Y=; b=KE7RiiLK92QwbQIaoGk7OU2M/0IG13cjKd5DG52iaolYHko1LxtmRzN0fe/HbQ1XCA NowkbLYMXzyxQ0lZPc3Rfuhy/xHs4AUYFX0RNcYVFcvHabmxEQA8IkxXF+f2MAWRaTXo n2wYv4561ReqGmhR62qr4kJwE62aLIBskqFNkvZRRGQaPgWNFbhdvyDdf62bH/7jrWUE YnCfsUyDDzDndXldLrGyadJC0QnHqnZ8zksw7L0fm2AxqTeESirnQprxljC9HNuFhFmq Y9TOsOEJk3rLaeD349wjl8BA0k9k37dF2efOs8SAE8rQlq+Jw5MnO/1t/ksC6fZtEIms JqxQ== X-Gm-Message-State: AOJu0Yy2m2s5pR3CbKddQJQrf2GZYcQyr6xHBG7t88vvXZH/pMiIiQXZ BOEAun50QGLHKxuDswVBKFrW0QynRJEw+rJtjLG5iWch/C+LE4rVv2i2ihWGz6U= X-Google-Smtp-Source: AGHT+IEGY/hr16dwZ5IcNgx/CmauHPsaJLzWX/B57eF+lGPF5KPQ1FqoEPCzGGqVJ/TlkmMwP9I3yQ== X-Received: by 2002:ac2:5632:0:b0:510:15b3:4f84 with SMTP id b18-20020ac25632000000b0051015b34f84mr26892lff.12.1706226645702; Thu, 25 Jan 2024 15:50:45 -0800 (PST) Received: from [172.30.205.155] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id a21-20020a195f55000000b005100af37fbcsm10614lfj.166.2024.01.25.15.50.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 15:50:45 -0800 (PST) Message-ID: Date: Fri, 26 Jan 2024 00:50:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 2/2] arm64: dts: qcom: msm8953: Add GPU Content-Language: en-US To: Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vladimir Lypak Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240125-msm8953-gpu-v1-0-f6493a5951f3@z3ntu.xyz> <20240125-msm8953-gpu-v1-2-f6493a5951f3@z3ntu.xyz> From: Konrad Dybcio In-Reply-To: <20240125-msm8953-gpu-v1-2-f6493a5951f3@z3ntu.xyz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/25/24 22:56, Luca Weiss wrote: > From: Vladimir Lypak > > Add the GPU node for the Adreno 506 found on this family of SoCs. The > clock speeds are a bit different per SoC variant, SDM450 maxes out at > 600MHz while MSM8953 (= SDM625) goes up to 650MHz and SDM632 goes up to > 725MHz. > > To achieve this, create a new sdm450.dtsi to hold the 600MHz OPP and > use the new dtsi for sdm450-motorola-ali. > > Signed-off-by: Vladimir Lypak > Co-developed-by: Luca Weiss > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/msm8953.dtsi | 115 +++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dts | 2 +- > arch/arm64/boot/dts/qcom/sdm450.dtsi | 14 +++ > arch/arm64/boot/dts/qcom/sdm632.dtsi | 8 ++ > 4 files changed, 138 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi > index 91d083871ab0..1fe0c0c4fd15 100644 > --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi > @@ -1046,6 +1046,94 @@ mdss_dsi1_phy: phy@1a96400 { > }; > }; > > + gpu: gpu@1c00000 { > + compatible = "qcom,adreno-506.0", "qcom,adreno"; > + reg = <0x01c00000 0x40000>; > + reg-names = "kgsl_3d0_reg_memory"; > + interrupts = ; > + > + clocks = <&gcc GCC_OXILI_GFX3D_CLK>, > + <&gcc GCC_OXILI_AHB_CLK>, > + <&gcc GCC_BIMC_GFX_CLK>, > + <&gcc GCC_BIMC_GPU_CLK>, > + <&gcc GCC_OXILI_TIMER_CLK>, > + <&gcc GCC_OXILI_AON_CLK>; > + clock-names = "core", > + "iface", > + "mem_iface", > + "alt_mem_iface", > + "rbbmtimer", > + "alwayson"; > + power-domains = <&gcc OXILI_GX_GDSC>; > + > + iommus = <&gpu_iommu 0>; > + operating-points-v2 = <&gpu_opp_table>; > + > + #cooling-cells = <2>; > + > + status = "disabled"; > + > + zap-shader { > + memory-region = <&zap_shader_region>; > + }; > + > + gpu_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-19200000 { > + opp-hz = /bits/ 64 <19200000>; > + opp-supported-hw = <0xff>; > + required-opps = <&rpmpd_opp_min_svs>; > + }; If you remove all OPPs but this one, can the GPU still spit out pixels? Konrad