* [kbuild] drivers/vdpa/virtio_pci/vp_vdpa.c:421 vp_vdpa_probe() warn: missing error code 'ret'
@ 2021-06-23 9:21 Dan Carpenter
2021-06-23 19:57 ` Michael S. Tsirkin
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2021-06-23 9:21 UTC (permalink / raw)
To: kbuild, Jason Wang
Cc: lkp, kbuild-all, linux-kernel, Michael S. Tsirkin, Eli Cohen
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0c18f29aae7ce3dadd26d8ee3505d07cc982df75
commit: 11d8ffed00b231356008b35a3b0bc192e42333fa vp_vdpa: switch to use vp_modern_map_vq_notify()
config: microblaze-randconfig-m031-20210622 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/vdpa/virtio_pci/vp_vdpa.c:421 vp_vdpa_probe() warn: missing error code 'ret'
Old smatch warnings:
drivers/vdpa/virtio_pci/vp_vdpa.c:168 vp_vdpa_request_irq() warn: inconsistent indenting
vim +/ret +421 drivers/vdpa/virtio_pci/vp_vdpa.c
64b9f64f80a6f4 Jason Wang 2021-02-23 367 static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
64b9f64f80a6f4 Jason Wang 2021-02-23 368 {
64b9f64f80a6f4 Jason Wang 2021-02-23 369 struct virtio_pci_modern_device *mdev;
64b9f64f80a6f4 Jason Wang 2021-02-23 370 struct device *dev = &pdev->dev;
64b9f64f80a6f4 Jason Wang 2021-02-23 371 struct vp_vdpa *vp_vdpa;
64b9f64f80a6f4 Jason Wang 2021-02-23 372 int ret, i;
64b9f64f80a6f4 Jason Wang 2021-02-23 373
64b9f64f80a6f4 Jason Wang 2021-02-23 374 ret = pcim_enable_device(pdev);
64b9f64f80a6f4 Jason Wang 2021-02-23 375 if (ret)
64b9f64f80a6f4 Jason Wang 2021-02-23 376 return ret;
64b9f64f80a6f4 Jason Wang 2021-02-23 377
64b9f64f80a6f4 Jason Wang 2021-02-23 378 vp_vdpa = vdpa_alloc_device(struct vp_vdpa, vdpa,
64b9f64f80a6f4 Jason Wang 2021-02-23 379 dev, &vp_vdpa_ops, NULL);
64b9f64f80a6f4 Jason Wang 2021-02-23 380 if (vp_vdpa == NULL) {
64b9f64f80a6f4 Jason Wang 2021-02-23 381 dev_err(dev, "vp_vdpa: Failed to allocate vDPA structure\n");
64b9f64f80a6f4 Jason Wang 2021-02-23 382 return -ENOMEM;
64b9f64f80a6f4 Jason Wang 2021-02-23 383 }
64b9f64f80a6f4 Jason Wang 2021-02-23 384
64b9f64f80a6f4 Jason Wang 2021-02-23 385 mdev = &vp_vdpa->mdev;
64b9f64f80a6f4 Jason Wang 2021-02-23 386 mdev->pci_dev = pdev;
64b9f64f80a6f4 Jason Wang 2021-02-23 387
64b9f64f80a6f4 Jason Wang 2021-02-23 388 ret = vp_modern_probe(mdev);
64b9f64f80a6f4 Jason Wang 2021-02-23 389 if (ret) {
64b9f64f80a6f4 Jason Wang 2021-02-23 390 dev_err(&pdev->dev, "Failed to probe modern PCI device\n");
64b9f64f80a6f4 Jason Wang 2021-02-23 391 goto err;
64b9f64f80a6f4 Jason Wang 2021-02-23 392 }
64b9f64f80a6f4 Jason Wang 2021-02-23 393
64b9f64f80a6f4 Jason Wang 2021-02-23 394 pci_set_master(pdev);
64b9f64f80a6f4 Jason Wang 2021-02-23 395 pci_set_drvdata(pdev, vp_vdpa);
64b9f64f80a6f4 Jason Wang 2021-02-23 396
64b9f64f80a6f4 Jason Wang 2021-02-23 397 vp_vdpa->vdpa.dma_dev = &pdev->dev;
64b9f64f80a6f4 Jason Wang 2021-02-23 398 vp_vdpa->queues = vp_modern_get_num_queues(mdev);
64b9f64f80a6f4 Jason Wang 2021-02-23 399
64b9f64f80a6f4 Jason Wang 2021-02-23 400 ret = devm_add_action_or_reset(dev, vp_vdpa_free_irq_vectors, pdev);
64b9f64f80a6f4 Jason Wang 2021-02-23 401 if (ret) {
64b9f64f80a6f4 Jason Wang 2021-02-23 402 dev_err(&pdev->dev,
64b9f64f80a6f4 Jason Wang 2021-02-23 403 "Failed for adding devres for freeing irq vectors\n");
64b9f64f80a6f4 Jason Wang 2021-02-23 404 goto err;
64b9f64f80a6f4 Jason Wang 2021-02-23 405 }
64b9f64f80a6f4 Jason Wang 2021-02-23 406
64b9f64f80a6f4 Jason Wang 2021-02-23 407 vp_vdpa->vring = devm_kcalloc(&pdev->dev, vp_vdpa->queues,
64b9f64f80a6f4 Jason Wang 2021-02-23 408 sizeof(*vp_vdpa->vring),
64b9f64f80a6f4 Jason Wang 2021-02-23 409 GFP_KERNEL);
64b9f64f80a6f4 Jason Wang 2021-02-23 410 if (!vp_vdpa->vring) {
64b9f64f80a6f4 Jason Wang 2021-02-23 411 ret = -ENOMEM;
64b9f64f80a6f4 Jason Wang 2021-02-23 412 dev_err(&pdev->dev, "Fail to allocate virtqueues\n");
64b9f64f80a6f4 Jason Wang 2021-02-23 413 goto err;
64b9f64f80a6f4 Jason Wang 2021-02-23 414 }
64b9f64f80a6f4 Jason Wang 2021-02-23 415
64b9f64f80a6f4 Jason Wang 2021-02-23 416 for (i = 0; i < vp_vdpa->queues; i++) {
64b9f64f80a6f4 Jason Wang 2021-02-23 417 vp_vdpa->vring[i].irq = VIRTIO_MSI_NO_VECTOR;
11d8ffed00b231 Jason Wang 2021-04-15 418 vp_vdpa->vring[i].notify = vp_modern_map_vq_notify(mdev, i);
11d8ffed00b231 Jason Wang 2021-04-15 419 if (!vp_vdpa->vring[i].notify) {
11d8ffed00b231 Jason Wang 2021-04-15 420 dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
ret = -ENOMEM;?
11d8ffed00b231 Jason Wang 2021-04-15 @421 goto err;
11d8ffed00b231 Jason Wang 2021-04-15 422 }
64b9f64f80a6f4 Jason Wang 2021-02-23 423 }
64b9f64f80a6f4 Jason Wang 2021-02-23 424 vp_vdpa->config_irq = VIRTIO_MSI_NO_VECTOR;
64b9f64f80a6f4 Jason Wang 2021-02-23 425
64b9f64f80a6f4 Jason Wang 2021-02-23 426 ret = vdpa_register_device(&vp_vdpa->vdpa, vp_vdpa->queues);
64b9f64f80a6f4 Jason Wang 2021-02-23 427 if (ret) {
64b9f64f80a6f4 Jason Wang 2021-02-23 428 dev_err(&pdev->dev, "Failed to register to vdpa bus\n");
64b9f64f80a6f4 Jason Wang 2021-02-23 429 goto err;
64b9f64f80a6f4 Jason Wang 2021-02-23 430 }
64b9f64f80a6f4 Jason Wang 2021-02-23 431
64b9f64f80a6f4 Jason Wang 2021-02-23 432 return 0;
64b9f64f80a6f4 Jason Wang 2021-02-23 433
64b9f64f80a6f4 Jason Wang 2021-02-23 434 err:
64b9f64f80a6f4 Jason Wang 2021-02-23 435 put_device(&vp_vdpa->vdpa.dev);
64b9f64f80a6f4 Jason Wang 2021-02-23 436 return ret;
64b9f64f80a6f4 Jason Wang 2021-02-23 437 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [kbuild] drivers/vdpa/virtio_pci/vp_vdpa.c:421 vp_vdpa_probe() warn: missing error code 'ret'
2021-06-23 9:21 [kbuild] drivers/vdpa/virtio_pci/vp_vdpa.c:421 vp_vdpa_probe() warn: missing error code 'ret' Dan Carpenter
@ 2021-06-23 19:57 ` Michael S. Tsirkin
2021-06-24 4:00 ` Jason Wang
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2021-06-23 19:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: kbuild, Jason Wang, lkp, kbuild-all, linux-kernel, Eli Cohen
On Wed, Jun 23, 2021 at 12:21:36PM +0300, Dan Carpenter wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 0c18f29aae7ce3dadd26d8ee3505d07cc982df75
> commit: 11d8ffed00b231356008b35a3b0bc192e42333fa vp_vdpa: switch to use vp_modern_map_vq_notify()
> config: microblaze-randconfig-m031-20210622 (attached as .config)
> compiler: microblaze-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> New smatch warnings:
> drivers/vdpa/virtio_pci/vp_vdpa.c:421 vp_vdpa_probe() warn: missing error code 'ret'
>
> Old smatch warnings:
> drivers/vdpa/virtio_pci/vp_vdpa.c:168 vp_vdpa_request_irq() warn: inconsistent indenting
>
> vim +/ret +421 drivers/vdpa/virtio_pci/vp_vdpa.c
>
> 64b9f64f80a6f4 Jason Wang 2021-02-23 367 static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> 64b9f64f80a6f4 Jason Wang 2021-02-23 368 {
> 64b9f64f80a6f4 Jason Wang 2021-02-23 369 struct virtio_pci_modern_device *mdev;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 370 struct device *dev = &pdev->dev;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 371 struct vp_vdpa *vp_vdpa;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 372 int ret, i;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 373
> 64b9f64f80a6f4 Jason Wang 2021-02-23 374 ret = pcim_enable_device(pdev);
> 64b9f64f80a6f4 Jason Wang 2021-02-23 375 if (ret)
> 64b9f64f80a6f4 Jason Wang 2021-02-23 376 return ret;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 377
> 64b9f64f80a6f4 Jason Wang 2021-02-23 378 vp_vdpa = vdpa_alloc_device(struct vp_vdpa, vdpa,
> 64b9f64f80a6f4 Jason Wang 2021-02-23 379 dev, &vp_vdpa_ops, NULL);
> 64b9f64f80a6f4 Jason Wang 2021-02-23 380 if (vp_vdpa == NULL) {
> 64b9f64f80a6f4 Jason Wang 2021-02-23 381 dev_err(dev, "vp_vdpa: Failed to allocate vDPA structure\n");
> 64b9f64f80a6f4 Jason Wang 2021-02-23 382 return -ENOMEM;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 383 }
> 64b9f64f80a6f4 Jason Wang 2021-02-23 384
> 64b9f64f80a6f4 Jason Wang 2021-02-23 385 mdev = &vp_vdpa->mdev;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 386 mdev->pci_dev = pdev;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 387
> 64b9f64f80a6f4 Jason Wang 2021-02-23 388 ret = vp_modern_probe(mdev);
> 64b9f64f80a6f4 Jason Wang 2021-02-23 389 if (ret) {
> 64b9f64f80a6f4 Jason Wang 2021-02-23 390 dev_err(&pdev->dev, "Failed to probe modern PCI device\n");
> 64b9f64f80a6f4 Jason Wang 2021-02-23 391 goto err;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 392 }
> 64b9f64f80a6f4 Jason Wang 2021-02-23 393
> 64b9f64f80a6f4 Jason Wang 2021-02-23 394 pci_set_master(pdev);
> 64b9f64f80a6f4 Jason Wang 2021-02-23 395 pci_set_drvdata(pdev, vp_vdpa);
> 64b9f64f80a6f4 Jason Wang 2021-02-23 396
> 64b9f64f80a6f4 Jason Wang 2021-02-23 397 vp_vdpa->vdpa.dma_dev = &pdev->dev;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 398 vp_vdpa->queues = vp_modern_get_num_queues(mdev);
> 64b9f64f80a6f4 Jason Wang 2021-02-23 399
> 64b9f64f80a6f4 Jason Wang 2021-02-23 400 ret = devm_add_action_or_reset(dev, vp_vdpa_free_irq_vectors, pdev);
> 64b9f64f80a6f4 Jason Wang 2021-02-23 401 if (ret) {
> 64b9f64f80a6f4 Jason Wang 2021-02-23 402 dev_err(&pdev->dev,
> 64b9f64f80a6f4 Jason Wang 2021-02-23 403 "Failed for adding devres for freeing irq vectors\n");
> 64b9f64f80a6f4 Jason Wang 2021-02-23 404 goto err;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 405 }
> 64b9f64f80a6f4 Jason Wang 2021-02-23 406
> 64b9f64f80a6f4 Jason Wang 2021-02-23 407 vp_vdpa->vring = devm_kcalloc(&pdev->dev, vp_vdpa->queues,
> 64b9f64f80a6f4 Jason Wang 2021-02-23 408 sizeof(*vp_vdpa->vring),
> 64b9f64f80a6f4 Jason Wang 2021-02-23 409 GFP_KERNEL);
> 64b9f64f80a6f4 Jason Wang 2021-02-23 410 if (!vp_vdpa->vring) {
> 64b9f64f80a6f4 Jason Wang 2021-02-23 411 ret = -ENOMEM;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 412 dev_err(&pdev->dev, "Fail to allocate virtqueues\n");
> 64b9f64f80a6f4 Jason Wang 2021-02-23 413 goto err;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 414 }
> 64b9f64f80a6f4 Jason Wang 2021-02-23 415
> 64b9f64f80a6f4 Jason Wang 2021-02-23 416 for (i = 0; i < vp_vdpa->queues; i++) {
> 64b9f64f80a6f4 Jason Wang 2021-02-23 417 vp_vdpa->vring[i].irq = VIRTIO_MSI_NO_VECTOR;
> 11d8ffed00b231 Jason Wang 2021-04-15 418 vp_vdpa->vring[i].notify = vp_modern_map_vq_notify(mdev, i);
> 11d8ffed00b231 Jason Wang 2021-04-15 419 if (!vp_vdpa->vring[i].notify) {
> 11d8ffed00b231 Jason Wang 2021-04-15 420 dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
>
> ret = -ENOMEM;?
More like EINVAL
> 11d8ffed00b231 Jason Wang 2021-04-15 @421 goto err;
> 11d8ffed00b231 Jason Wang 2021-04-15 422 }
> 64b9f64f80a6f4 Jason Wang 2021-02-23 423 }
> 64b9f64f80a6f4 Jason Wang 2021-02-23 424 vp_vdpa->config_irq = VIRTIO_MSI_NO_VECTOR;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 425
> 64b9f64f80a6f4 Jason Wang 2021-02-23 426 ret = vdpa_register_device(&vp_vdpa->vdpa, vp_vdpa->queues);
> 64b9f64f80a6f4 Jason Wang 2021-02-23 427 if (ret) {
> 64b9f64f80a6f4 Jason Wang 2021-02-23 428 dev_err(&pdev->dev, "Failed to register to vdpa bus\n");
> 64b9f64f80a6f4 Jason Wang 2021-02-23 429 goto err;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 430 }
> 64b9f64f80a6f4 Jason Wang 2021-02-23 431
> 64b9f64f80a6f4 Jason Wang 2021-02-23 432 return 0;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 433
> 64b9f64f80a6f4 Jason Wang 2021-02-23 434 err:
> 64b9f64f80a6f4 Jason Wang 2021-02-23 435 put_device(&vp_vdpa->vdpa.dev);
> 64b9f64f80a6f4 Jason Wang 2021-02-23 436 return ret;
> 64b9f64f80a6f4 Jason Wang 2021-02-23 437 }
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
> _______________________________________________
> kbuild mailing list -- kbuild@lists.01.org
> To unsubscribe send an email to kbuild-leave@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [kbuild] drivers/vdpa/virtio_pci/vp_vdpa.c:421 vp_vdpa_probe() warn: missing error code 'ret'
2021-06-23 19:57 ` Michael S. Tsirkin
@ 2021-06-24 4:00 ` Jason Wang
0 siblings, 0 replies; 3+ messages in thread
From: Jason Wang @ 2021-06-24 4:00 UTC (permalink / raw)
To: Michael S. Tsirkin, Dan Carpenter
Cc: kbuild, lkp, kbuild-all, linux-kernel, Eli Cohen
在 2021/6/24 上午3:57, Michael S. Tsirkin 写道:
> On Wed, Jun 23, 2021 at 12:21:36PM +0300, Dan Carpenter wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: 0c18f29aae7ce3dadd26d8ee3505d07cc982df75
>> commit: 11d8ffed00b231356008b35a3b0bc192e42333fa vp_vdpa: switch to use vp_modern_map_vq_notify()
>> config: microblaze-randconfig-m031-20210622 (attached as .config)
>> compiler: microblaze-linux-gcc (GCC) 9.3.0
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> New smatch warnings:
>> drivers/vdpa/virtio_pci/vp_vdpa.c:421 vp_vdpa_probe() warn: missing error code 'ret'
>>
>> Old smatch warnings:
>> drivers/vdpa/virtio_pci/vp_vdpa.c:168 vp_vdpa_request_irq() warn: inconsistent indenting
>>
>> vim +/ret +421 drivers/vdpa/virtio_pci/vp_vdpa.c
>>
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 367 static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 368 {
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 369 struct virtio_pci_modern_device *mdev;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 370 struct device *dev = &pdev->dev;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 371 struct vp_vdpa *vp_vdpa;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 372 int ret, i;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 373
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 374 ret = pcim_enable_device(pdev);
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 375 if (ret)
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 376 return ret;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 377
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 378 vp_vdpa = vdpa_alloc_device(struct vp_vdpa, vdpa,
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 379 dev, &vp_vdpa_ops, NULL);
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 380 if (vp_vdpa == NULL) {
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 381 dev_err(dev, "vp_vdpa: Failed to allocate vDPA structure\n");
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 382 return -ENOMEM;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 383 }
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 384
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 385 mdev = &vp_vdpa->mdev;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 386 mdev->pci_dev = pdev;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 387
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 388 ret = vp_modern_probe(mdev);
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 389 if (ret) {
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 390 dev_err(&pdev->dev, "Failed to probe modern PCI device\n");
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 391 goto err;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 392 }
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 393
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 394 pci_set_master(pdev);
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 395 pci_set_drvdata(pdev, vp_vdpa);
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 396
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 397 vp_vdpa->vdpa.dma_dev = &pdev->dev;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 398 vp_vdpa->queues = vp_modern_get_num_queues(mdev);
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 399
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 400 ret = devm_add_action_or_reset(dev, vp_vdpa_free_irq_vectors, pdev);
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 401 if (ret) {
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 402 dev_err(&pdev->dev,
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 403 "Failed for adding devres for freeing irq vectors\n");
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 404 goto err;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 405 }
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 406
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 407 vp_vdpa->vring = devm_kcalloc(&pdev->dev, vp_vdpa->queues,
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 408 sizeof(*vp_vdpa->vring),
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 409 GFP_KERNEL);
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 410 if (!vp_vdpa->vring) {
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 411 ret = -ENOMEM;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 412 dev_err(&pdev->dev, "Fail to allocate virtqueues\n");
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 413 goto err;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 414 }
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 415
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 416 for (i = 0; i < vp_vdpa->queues; i++) {
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 417 vp_vdpa->vring[i].irq = VIRTIO_MSI_NO_VECTOR;
>> 11d8ffed00b231 Jason Wang 2021-04-15 418 vp_vdpa->vring[i].notify = vp_modern_map_vq_notify(mdev, i);
>> 11d8ffed00b231 Jason Wang 2021-04-15 419 if (!vp_vdpa->vring[i].notify) {
>> 11d8ffed00b231 Jason Wang 2021-04-15 420 dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
>>
>> ret = -ENOMEM;?
>
> More like EINVAL
Right, patch posted.
Thanks
>
>> 11d8ffed00b231 Jason Wang 2021-04-15 @421 goto err;
>> 11d8ffed00b231 Jason Wang 2021-04-15 422 }
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 423 }
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 424 vp_vdpa->config_irq = VIRTIO_MSI_NO_VECTOR;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 425
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 426 ret = vdpa_register_device(&vp_vdpa->vdpa, vp_vdpa->queues);
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 427 if (ret) {
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 428 dev_err(&pdev->dev, "Failed to register to vdpa bus\n");
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 429 goto err;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 430 }
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 431
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 432 return 0;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 433
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 434 err:
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 435 put_device(&vp_vdpa->vdpa.dev);
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 436 return ret;
>> 64b9f64f80a6f4 Jason Wang 2021-02-23 437 }
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>>
>> _______________________________________________
>> kbuild mailing list -- kbuild@lists.01.org
>> To unsubscribe send an email to kbuild-leave@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-24 4:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 9:21 [kbuild] drivers/vdpa/virtio_pci/vp_vdpa.c:421 vp_vdpa_probe() warn: missing error code 'ret' Dan Carpenter
2021-06-23 19:57 ` Michael S. Tsirkin
2021-06-24 4:00 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).