From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBD98C4708A for ; Thu, 27 May 2021 04:01:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC7FB610CC for ; Thu, 27 May 2021 04:01:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229617AbhE0EC7 (ORCPT ); Thu, 27 May 2021 00:02:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43244 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbhE0EC5 (ORCPT ); Thu, 27 May 2021 00:02:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622088084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YFTuqobSNbOR8Wq6p+a7ao2//KKDypGgE4erIL0zlEM=; b=b1s5HhanVptRawpD407ioiyNwHcd5++t0lF8jgqWEmxayipEJjoHhsy36R0HY+/puxVFzd c/RUmeVVbvVdCqvqwHpaP+r+KbAs/SoAtwP/ep0CfxsFyqWyKREoMzXzNckyKS7h7PiRVQ THosOtz/0IL3wOlMYc+6MpeJvz1XP7E= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-iurhHPMrPJaKc5Ok0p2ueA-1; Thu, 27 May 2021 00:01:22 -0400 X-MC-Unique: iurhHPMrPJaKc5Ok0p2ueA-1 Received: by mail-pl1-f198.google.com with SMTP id 2-20020a1709020202b02900eecb50c2deso1693573plc.0 for ; Wed, 26 May 2021 21:01:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=YFTuqobSNbOR8Wq6p+a7ao2//KKDypGgE4erIL0zlEM=; b=odGwhwOLZquC43W8+gWODXL/q4RyC7CTOpqwWrdsaif4M44dGFuwQovseIgi92Wbat ciLoBiD/pWEvr6e2PY6dzNZxJqqab+U6NkG1A4z5/cFTtWd2EN69bTmOswl76Be1IVb7 emIMPumZsuKkjtxgMwUzd+hXMVGswp8ddfnE6M6bGJrnKfbsC2IuDRamcIhdnUv76Grw 4vFFL0RIvDV68QBfEjd1zzGgRve70j+fM9fauBScfQ3UWkEwErScb86YqMB6HU/SjQjs fc+EAxu+uvxC24gYfgpGfM4wBKT7lE6eT5+thM+RBKUImga7MgftIVYdxG6vmWczh/+f NqrQ== X-Gm-Message-State: AOAM533fF92cyww3Wx+qj4mEcyTFWKzpKArfrkPAuNhbc4EHhKnHzwBN WQ6+MqkG8/v56qAxbxgktyEA7RsGZA2eFYe4e45LKrQErHYeMLrpYVNRETOEmJ/SP/Uo/e0gD/9 XdJqtQp5z7peIufZnN9VBmC36 X-Received: by 2002:a05:6a00:1705:b029:2e7:60df:7413 with SMTP id h5-20020a056a001705b02902e760df7413mr1764226pfc.48.1622088081687; Wed, 26 May 2021 21:01:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzT94njfKbzIhMIA4Q1yN5K+12taVUkR5i/koVkhVbs5xSnZwAsySH3w+t2YxLpWBdJTfGJuQ== X-Received: by 2002:a05:6a00:1705:b029:2e7:60df:7413 with SMTP id h5-20020a056a001705b02902e760df7413mr1764191pfc.48.1622088081275; Wed, 26 May 2021 21:01:21 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id p14sm529443pgb.2.2021.05.26.21.01.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 May 2021 21:01:20 -0700 (PDT) Subject: Re: [PATCH v3 3/4] virtio: fix up virtio_disable_cb To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: Jakub Kicinski , Wei Wang , David Miller , netdev@vger.kernel.org, Willem de Bruijn , virtualization@lists.linux-foundation.org References: <20210526082423.47837-1-mst@redhat.com> <20210526082423.47837-4-mst@redhat.com> From: Jason Wang Message-ID: Date: Thu, 27 May 2021 12:01:16 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210526082423.47837-4-mst@redhat.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/5/26 ÏÂÎç4:24, Michael S. Tsirkin дµÀ: > virtio_disable_cb is currently a nop for split ring with event index. > This is because it used to be always called from a callback when we know > device won't trigger more events until we update the index. However, > now that we run with interrupts enabled a lot we also poll without a > callback so that is different: disabling callbacks will help reduce the > number of spurious interrupts. > Further, if using event index with a packed ring, and if being called > from a callback, we actually do disable interrupts which is unnecessary. > > Fix both issues by tracking whenever we get a callback. If that is > the case disabling interrupts with event index can be a nop. This seems unnecessary: 1) we check avail_flags_shadow before touching touching the index 2) The nop is not good at least for split, if we choose a suitable event index, it can help to reduce the chance of 1/N interrupt, (see below). > If not the case disable interrupts. Note: with a split ring > there's no explicit "no interrupts" value. For now we write > a fixed value so our chance of triggering an interupt > is 1/ring size. 1/65535 actually? If yes, do we still need this trick? > It's probably better to write something > related to the last used index there to reduce the chance > even further. For now I'm keeping it simple. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/virtio/virtio_ring.c | 26 +++++++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 71e16b53e9c1..88f0b16b11b8 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -113,6 +113,9 @@ struct vring_virtqueue { > /* Last used index we've seen. */ > u16 last_used_idx; > > + /* Hint for event idx: already triggered no need to disable. */ > + bool event_triggered; > + > union { > /* Available for split ring */ > struct { > @@ -739,7 +742,10 @@ static void virtqueue_disable_cb_split(struct virtqueue *_vq) > > if (!(vq->split.avail_flags_shadow & VRING_AVAIL_F_NO_INTERRUPT)) { > vq->split.avail_flags_shadow |= VRING_AVAIL_F_NO_INTERRUPT; > - if (!vq->event) > + if (vq->event) > + /* TODO: this is a hack. Figure out a cleaner value to write. */ > + vring_used_event(&vq->split.vring) = 0x0; used_idx or last_used_idx seems better here. > + else > vq->split.vring.avail->flags = > cpu_to_virtio16(_vq->vdev, > vq->split.avail_flags_shadow); > @@ -1605,6 +1611,7 @@ static struct virtqueue *vring_create_virtqueue_packed( > vq->weak_barriers = weak_barriers; > vq->broken = false; > vq->last_used_idx = 0; > + vq->event_triggered = false; > vq->num_added = 0; > vq->packed_ring = true; > vq->use_dma_api = vring_use_dma_api(vdev); > @@ -1919,6 +1926,12 @@ void virtqueue_disable_cb(struct virtqueue *_vq) > { > struct vring_virtqueue *vq = to_vvq(_vq); > > + /* If device triggered an event already it won't trigger one again: > + * no need to disable. > + */ > + if (vq->event_triggered) > + return; > + > if (vq->packed_ring) > virtqueue_disable_cb_packed(_vq); > else > @@ -1942,6 +1955,9 @@ unsigned virtqueue_enable_cb_prepare(struct virtqueue *_vq) > { > struct vring_virtqueue *vq = to_vvq(_vq); > > + if (vq->event_triggered) > + vq->event_triggered = false; > + > return vq->packed_ring ? virtqueue_enable_cb_prepare_packed(_vq) : > virtqueue_enable_cb_prepare_split(_vq); > } > @@ -2005,6 +2021,9 @@ bool virtqueue_enable_cb_delayed(struct virtqueue *_vq) > { > struct vring_virtqueue *vq = to_vvq(_vq); > > + if (vq->event_triggered) > + vq->event_triggered = false; > + > return vq->packed_ring ? virtqueue_enable_cb_delayed_packed(_vq) : > virtqueue_enable_cb_delayed_split(_vq); > } Miss the case of virtqueue_enable_cb()? Thanks > @@ -2044,6 +2063,10 @@ irqreturn_t vring_interrupt(int irq, void *_vq) > if (unlikely(vq->broken)) > return IRQ_HANDLED; > > + /* Just a hint for performance: so it's ok that this can be racy! */ > + if (vq->event) > + vq->event_triggered = true; > + > pr_debug("virtqueue callback for %p (%p)\n", vq, vq->vq.callback); > if (vq->vq.callback) > vq->vq.callback(&vq->vq); > @@ -2083,6 +2106,7 @@ struct virtqueue *__vring_new_virtqueue(unsigned int index, > vq->weak_barriers = weak_barriers; > vq->broken = false; > vq->last_used_idx = 0; > + vq->event_triggered = false; > vq->num_added = 0; > vq->use_dma_api = vring_use_dma_api(vdev); > #ifdef DEBUG