From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8450: Add TCSR halt register space
Date: Wed, 11 Jan 2023 11:00:02 +0100 [thread overview]
Message-ID: <c5dc8042-717b-22eb-79f6-d18ab10d6685@linaro.org> (raw)
In-Reply-To: <ab6a99da-e91b-20de-3126-3f1f94ce277b@linaro.org>
On 11/01/2023 10:59, Krzysztof Kozlowski wrote:
> On 11/01/2023 10:20, Mukesh Ojha wrote:
>> Add TCSR register space and refer it from scm node, so that
>> it can be used by SCM driver.
>>
>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> index 5704750..e0fa733 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> @@ -270,6 +270,7 @@
>> firmware {
>> scm: scm {
>> compatible = "qcom,scm-sm8450", "qcom,scm";
>> + qcom,dload-mode = <&tcsr 0x13000>;
>> interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>;
>> #reset-cells = <1>;
>> };
>> @@ -1986,6 +1987,11 @@
>> #hwlock-cells = <1>;
>> };
>>
>> + tcsr: syscon@1fc0000 {
>> + compatible = "syscon";
>
> This is not allowed by itself.
Eh, that was not proper English... I wanted to say: This is not allowed
on its own. You need specific compatible. ALWAYS.
> You should have warnings when running
> dtbs_check.
>
> Best regards,
> Krzysztof
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-11 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 9:20 [PATCH] arm64: dts: qcom: sm8450: Add TCSR halt register space Mukesh Ojha
2023-01-11 9:59 ` Krzysztof Kozlowski
2023-01-11 10:00 ` Krzysztof Kozlowski [this message]
2023-01-11 10:32 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5dc8042-717b-22eb-79f6-d18ab10d6685@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mojha@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).