From: asutoshd@codeaurora.org
To: cang@codeaurora.org, rnayak@codeaurora.org,
vinholikatti@gmail.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, kernel-team@android.com,
saravanak@google.com, salyzyn@google.com,
Andy Gross <agross@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH v2 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock scaling
Date: Wed, 23 Oct 2019 09:47:13 -0700 [thread overview]
Message-ID: <c5de4aac8672a2dd1b6048908da4a38e@codeaurora.org> (raw)
In-Reply-To: <1571848785-27698-2-git-send-email-asutoshd@codeaurora.org>
On 2019-10-23 09:39, Asutosh Das wrote:
> Qualcomm controller needs to be in hibern8 before scaling clocks.
> This change puts the controller in hibern8 state before scaling
> and brings it out after scaling of clocks.
>
> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
> ---
> drivers/scsi/ufs/ufs-qcom.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index a5b7148..d117088 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1305,6 +1305,9 @@ static int ufs_qcom_clk_scale_notify(struct
> ufs_hba *hba,
> int err = 0;
>
> if (status == PRE_CHANGE) {
> + err = ufshcd_uic_hibern8_enter(hba);
> + if (err)
> + return err;
> if (scale_up)
> err = ufs_qcom_clk_scale_up_pre_change(hba);
The error handling is not done here.
> else
> @@ -1324,6 +1327,7 @@ static int ufs_qcom_clk_scale_notify(struct
> ufs_hba *hba,
> dev_req_params->hs_rate,
> false);
> ufs_qcom_update_bus_bw_vote(host);
> + ufshcd_uic_hibern8_exit(hba);
> }
>
> out:
In the post-change condition as well, the error handling is not done.
On error, it should be brought out of hibernate.
I'll put up another change fixing that.
-asd
next prev parent reply other threads:[~2019-10-23 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 16:39 [PATCH v2 1/2] scsi: ufs: export hibern8 entry and exit Asutosh Das
2019-10-23 16:39 ` [PATCH v2 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock scaling Asutosh Das
2019-10-23 16:47 ` asutoshd [this message]
[not found] <cover.1632818942.git.nguyenb@codeaurora.org>
2021-09-28 9:06 ` Bao D. Nguyen
2021-09-29 3:16 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5de4aac8672a2dd1b6048908da4a38e@codeaurora.org \
--to=asutoshd@codeaurora.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pedrom.sousa@synopsys.com \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).