From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B24C1C433EF for ; Wed, 12 Jan 2022 09:45:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352167AbiALJpU (ORCPT ); Wed, 12 Jan 2022 04:45:20 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:49520 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1346466AbiALJpT (ORCPT ); Wed, 12 Jan 2022 04:45:19 -0500 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20C7J52B019096; Wed, 12 Jan 2022 10:44:32 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=QKXUvjkTnqfyuuJJ/9fLbLqUbNNWBj6UxoTZSD1VgXg=; b=0g/MsK1OiOZU3dq3G+D9GapTzmQoW0YuFw/h5Ckk73elOP3+Le70B19CLQZcWzaRyP+A CJJBRhXPyMms72FMVYJk3TOCHFDbI5dWJ6SRMK37GhUNW+Xo/92x3ZUQYRTNMetn/plf qJcjWFbMshrfUEyUXbAa96a9pb1pTnOQFHy/Va4Cm9oO1XzV1IU5a26vFN/B3CzB+UHH zpD3IaZSjYd4SMqVYH1WdlcLmzjSoZLij/SvntyI0C2GCNkF7D3DQ9W2G9qqPfn8IGo9 LUnkfzMr0E40eeuyzSNluk4L97Pk3TSMlhXoXbFvXqZctksW32DqKb/1XyS2fsZah23f aA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3dhtg9s0m5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Jan 2022 10:44:32 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 81091100034; Wed, 12 Jan 2022 10:44:28 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 72E2D218120; Wed, 12 Jan 2022 10:44:28 +0100 (CET) Received: from lmecxl0951.lme.st.com (10.75.127.46) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Wed, 12 Jan 2022 10:44:27 +0100 Subject: Re: [PATCH v2 6/6] drm/stm: ltdc: Drop format_mod_supported function To: =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , CC: , , , , , , , , , , , , , , , , , , , , , , , , References: <20211222090552.25972-1-jose.exposito89@gmail.com> <20211222090552.25972-7-jose.exposito89@gmail.com> From: yannick Fertre Message-ID: Date: Wed, 12 Jan 2022 10:44:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211222090552.25972-7-jose.exposito89@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-12_03,2022-01-11_01,2021-12-02_01 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello José, thanks for your patch. Reviewed-by: Yannick Fertre Tested-by: Yannick Fertre On 12/22/21 10:05 AM, José Expósito wrote: > The "drm_plane_funcs.format_mod_supported" can be removed in favor of > the default implementation. > > Signed-off-by: José Expósito > --- > drivers/gpu/drm/stm/ltdc.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index dbdee954692a..ef909e50f0e4 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -925,16 +925,6 @@ static void ltdc_plane_atomic_print_state(struct drm_printer *p, > fpsi->counter = 0; > } > > -static bool ltdc_plane_format_mod_supported(struct drm_plane *plane, > - u32 format, > - u64 modifier) > -{ > - if (modifier == DRM_FORMAT_MOD_LINEAR) > - return true; > - > - return false; > -} > - > static const struct drm_plane_funcs ltdc_plane_funcs = { > .update_plane = drm_atomic_helper_update_plane, > .disable_plane = drm_atomic_helper_disable_plane, > @@ -943,7 +933,6 @@ static const struct drm_plane_funcs ltdc_plane_funcs = { > .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_plane_destroy_state, > .atomic_print_state = ltdc_plane_atomic_print_state, > - .format_mod_supported = ltdc_plane_format_mod_supported, > }; > > static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs = { >