From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 992F6C28CC7 for ; Mon, 3 Jun 2019 06:57:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7229327C68 for ; Mon, 3 Jun 2019 06:57:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="LDZ3aPZP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727247AbfFCG5E (ORCPT ); Mon, 3 Jun 2019 02:57:04 -0400 Received: from smtp-fw-6002.amazon.com ([52.95.49.90]:56410 "EHLO smtp-fw-6002.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbfFCG5E (ORCPT ); Mon, 3 Jun 2019 02:57:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1559545022; x=1591081022; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=28ubXn7tIxBtQaVuAwhyLsuJAMZSspzvIGvKhunz4Ug=; b=LDZ3aPZPSYJn7p5wjgCoYuxgzyYs9SUDXLoXceSaYUdDlWrBCtcsNvlK BkOZi/kV03VE4hD0M00ql51YzMlvSz7KMPdNAT38RdmCFsVePQi0e6rB/ rfTrCH1DYnfhtRZC/G4R22dvzi8Dp/eb0R3R87s6oSMnhZO9a1XfgQkOT 8=; X-IronPort-AV: E=Sophos;i="5.60,545,1549929600"; d="scan'208";a="404727797" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2a-d0be17ee.us-west-2.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-6002.iad6.amazon.com with ESMTP; 03 Jun 2019 06:56:57 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2a-d0be17ee.us-west-2.amazon.com (Postfix) with ESMTPS id 582BDA22F8; Mon, 3 Jun 2019 06:56:56 +0000 (UTC) Received: from EX13D08UEE001.ant.amazon.com (10.43.62.126) by EX13MTAUEA001.ant.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 3 Jun 2019 06:56:56 +0000 Received: from EX13MTAUEE001.ant.amazon.com (10.43.62.200) by EX13D08UEE001.ant.amazon.com (10.43.62.126) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 3 Jun 2019 06:56:55 +0000 Received: from [10.95.119.163] (10.95.119.163) by mail-relay.amazon.com (10.43.62.226) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 3 Jun 2019 06:56:50 +0000 Subject: Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC To: "Herrenschmidt, Benjamin" , "robh+dt@kernel.org" , "Woodhouse, David" , "paulmck@linux.ibm.com" , "james.morse@arm.com" , "mchehab@kernel.org" , "mark.rutland@arm.com" , "gregkh@linuxfoundation.org" , "bp@alien8.de" , "davem@davemloft.net" , "nicolas.ferre@microchip.com" CC: "devicetree@vger.kernel.org" , "Shenhar, Talel" , "linux-kernel@vger.kernel.org" , "Chocron, Jonathan" , "Krupnik, Ronen" , "linux-edac@vger.kernel.org" , "Hanoch, Uri" References: <1559211329-13098-1-git-send-email-hhhawa@amazon.com> <1559211329-13098-3-git-send-email-hhhawa@amazon.com> From: "Hawa, Hanna" Message-ID: Date: Mon, 3 Jun 2019 09:56:44 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/2019 4:15 AM, Herrenschmidt, Benjamin wrote: > On Thu, 2019-05-30 at 11:19 -0700, Boris Petkov wrote: >> On May 30, 2019 3:15:29 AM PDT, Hanna Hawa wrote: >>> Add support for error detection and correction for Amazon's >>> Annapurna >>> Labs SoCs for L1/L2 caches. >> >> >> So this should be a driver for the whole annapurna platform and not >> only about the RAS functionality in an IP like the caches. See other >> ARM EDAC drivers in drivers/edac/ for an example. > > This isn't terribly helpful, there's nothing telling anybody which of > those files corresponds to an ARM SoC :-) > > That said ... > > You really want a single EDAC driver that contains all the stuff for > the caches, the memory controller, etc... ? > > The idea here was to separate the core L1/L2 EDAC from the memory > controller EDAC I think ... Roben, Hanna, can you describe the long run > strategy here ? Correct our target to separate the L1/L2 EDAC from mc, and to maintain both in separate drivers. Thanks, Hanna > > Cheers, > Ben. >