linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Mark Brown <broonie@kernel.org>, Inki Dae <inki.dae@samsung.com>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [FAIL bisect] Sound card probe error
Date: Mon, 14 May 2018 15:34:29 +0200	[thread overview]
Message-ID: <c62a6f86-4c6f-f7ed-f615-93d6db7412ec@samsung.com> (raw)
In-Reply-To: <CAJKOXPeNJtmU2+8CdMRwXignMTetn=LScdcMspfkP3MVmTSHrg@mail.gmail.com>

On 05/14/2018 02:50 PM, Krzysztof Kozlowski wrote:
> On Mon, May 14, 2018 at 2:45 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On Mon, May 14, 2018 at 2:40 PM, Sylwester Nawrocki
>> <s.nawrocki@samsung.com> wrote:
>>> On 05/14/2018 02:29 PM, Krzysztof Kozlowski wrote:
>>>> Ah, I missed these messages because I was looking at err dmesg level
>>>> (and for some reason these are warn). Anyway do you have any thoughts
>>>> how is it connected with missing Odroid XU3 sound card and max98090
>>>> codec?
>>> One reason is that the DRM driver registers an ASoC codec object which
>>> is required for the sound card registration to complete. But I wonder
>>> why there is no any error messages related to this.
>> Thanks Marek and Sylwester. Another point is that probably OOPS later
>> should not happen...

> Separate topic (trim Cc list):
> 
> ... and this means that disabling Exynos DRM causes lack of Audio. I
> tried it now and indeed without DRM there is no audio again. I think
> it is not nice... There are not many such use cases but there are
> (playing audio from console/ssh with a headless board).\

As we discussed off the mailing list, what we could probably do now
is to add a compile time dependency on CONFIG_DRM_EXYNOS_HDMI, a fallback
to the max98098 codec only when the HDMI driver is disabled. 

That might require modifying snd_soc_of_get_dai_link_codecs() so it can 
skip optional codecs.

-- 
Regards,
Sylwester

  reply	other threads:[~2018-05-14 13:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180514101728epcas4p3108760546a415b36252df93dfe38e0fb@epcas4p3.samsung.com>
2018-05-14 10:17 ` [FAIL bisect] Sound card probe error Krzysztof Kozlowski
2018-05-14 12:22   ` Sylwester Nawrocki
2018-05-14 12:29     ` Krzysztof Kozlowski
2018-05-14 12:36       ` Marek Szyprowski
2018-05-14 12:40       ` Sylwester Nawrocki
2018-05-14 12:45         ` Krzysztof Kozlowski
2018-05-14 12:50           ` Krzysztof Kozlowski
2018-05-14 13:34             ` Sylwester Nawrocki [this message]
2018-05-14 12:30     ` Ulf Hansson
2018-05-14 12:43       ` Krzysztof Kozlowski
2018-05-14 14:35         ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c62a6f86-4c6f-f7ed-f615-93d6db7412ec@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=a.hajda@samsung.com \
    --cc=broonie@kernel.org \
    --cc=inki.dae@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).