From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: joro@8bytes.org, will@kernel.org, catalin.marinas@arm.com,
jean-philippe@linaro.org, inki.dae@samsung.com,
sw0312.kim@samsung.com, kyungmin.park@samsung.com,
tglx@linutronix.de, maz@kernel.org, alex.williamson@redhat.com,
cohuck@redhat.com, iommu@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH 2/3] iommu/dma: Move public interfaces to linux/iommu.h
Date: Mon, 22 Aug 2022 13:55:11 +0100 [thread overview]
Message-ID: <c64e838a-dace-73dd-8ab9-7284166cf742@arm.com> (raw)
In-Reply-To: <YwNmosMGZdGtY3LX@infradead.org>
On 2022-08-22 12:21, Christoph Hellwig wrote:
>> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
>> index 70393fbb57ed..79cb6eb560a8 100644
>> --- a/include/linux/iommu.h
>> +++ b/include/linux/iommu.h
>> @@ -1059,4 +1059,40 @@ void iommu_debugfs_setup(void);
>> static inline void iommu_debugfs_setup(void) {}
>> #endif
>>
>> +#ifdef CONFIG_IOMMU_DMA
>> +#include <linux/msi.h>
>
> I don't think msi.h is actually needed here.
>
> Just make the struct msi_desc and struct msi_msg forward declarations
> unconditional and we should be fine.
dma-iommu.c still needs to pick up msi.h for the actual definitions
somehow, so it seemed logical to keep things the same shape as before.
However I don't have a particularly strong preference either way.
Thanks,
Robin.
next prev parent reply other threads:[~2022-08-22 12:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 17:28 [PATCH 0/3] iommu/dma: Some housekeeping Robin Murphy
2022-08-16 17:28 ` [PATCH 1/3] iommu/dma: Clean up Kconfig Robin Murphy
2022-09-02 18:15 ` Catalin Marinas
2023-05-05 14:50 ` Jason Gunthorpe
2023-05-05 14:53 ` Robin Murphy
2023-05-05 19:22 ` Jason Gunthorpe
2022-08-16 17:28 ` [PATCH 2/3] iommu/dma: Move public interfaces to linux/iommu.h Robin Murphy
2022-08-17 12:19 ` Marc Zyngier
2022-08-22 11:21 ` Christoph Hellwig
2022-08-22 12:55 ` Robin Murphy [this message]
2022-09-02 18:16 ` Catalin Marinas
2022-08-16 17:28 ` [PATCH 3/3] iommu/dma: Make header private Robin Murphy
2022-09-07 12:49 ` [PATCH 0/3] iommu/dma: Some housekeeping Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c64e838a-dace-73dd-8ab9-7284166cf742@arm.com \
--to=robin.murphy@arm.com \
--cc=alex.williamson@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=cohuck@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=inki.dae@samsung.com \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).