archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <>
To: Martijn Coenen <>,,
Subject: Re: [PATCH v2] loop: change queue block size to match when using DIO.
Date: Tue, 1 Oct 2019 08:10:10 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 9/4/19 1:49 PM, Martijn Coenen wrote:
> The loop driver assumes that if the passed in fd is opened with
> O_DIRECT, the caller wants to use direct I/O on the loop device.
> However, if the underlying block device has a different block size than
> the loop block queue, direct I/O can't be enabled. Instead of requiring
> userspace to manually change the blocksize and re-enable direct I/O,
> just change the queue block sizes to match, as well as the io_min size.

Applied, thanks.

Jens Axboe

      parent reply	other threads:[~2019-10-01 14:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28 10:32 [PATCH] loop: change queue block size to match when using DIO Martijn Coenen
2019-08-30 15:50 ` Christoph Hellwig
2019-09-02 19:37   ` Martijn Coenen
2019-09-04 19:49 ` [PATCH v2] " Martijn Coenen
2019-09-10 10:12   ` Martijn Coenen
2019-09-30  8:24   ` Christoph Hellwig
2019-10-01 10:03     ` Martijn Coenen
2019-10-01 14:10   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).