From: Robin Murphy <robin.murphy@arm.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Russell King <linux@armlinux.org.uk>,
open list <linux-kernel@vger.kernel.org>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Gregory Fong <gregory.0xf0@gmail.com>,
Doug Berger <opendmb@gmail.com>,
Brian Norris <computersforpeace@gmail.com>
Subject: Re: [PATCH 0/3] ARM/PSCI: Fix THUMB2_KERNEL entry points
Date: Fri, 28 Sep 2018 09:08:19 +0100 [thread overview]
Message-ID: <c68b01ab-9077-73cc-8356-25a4e3a909f0@arm.com> (raw)
In-Reply-To: <20180927192711.26455-1-f.fainelli@gmail.com>
On 2018-09-27 8:27 PM, Florian Fainelli wrote:
> Hi all,
>
> While playing with THUMB2_KERNEL on ARCH_BRCMSTB, several issues came up
> which are addressed by these 3 patches.
Hmmm, PSCI looks to explicitly support Thumb entrypoints ("T32 support"
in section 6.4.3 of DEN0022D), so these changes smell a little of
papering over a more fundamental problem, which is presumably either
that Thumb symbols are not being resolved correctly, or that the
firmware you're using has a bug.
Robin.
> The THUMB() assembler macro is a no-op unless CONFIG_THUMB2_KERNEL so
> using it unconditionally for CONFIG_ARM should not cause a problem
> AFAICT.
>
> Those patches can all be independently picked up by their respective
> maintainers and don't depent on one another.
>
> Thank you!
>
> Florian Fainelli (3):
> firmware/psci: Fix cpu_resume entry points with THUMB2_KERNEL
> ARM: psci: Fix secondary core boot with THUMB2_KERNEL
> soc: bcm: brcmstb: Fix re-entry point with a THUMB2_KERNEL
>
> arch/arm/kernel/psci_smp.c | 4 ++--
> drivers/firmware/psci.c | 18 +++++++++++++++---
> drivers/soc/bcm/brcmstb/pm/pm-arm.c | 2 +-
> 3 files changed, 18 insertions(+), 6 deletions(-)
>
next prev parent reply other threads:[~2018-09-28 8:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 19:27 [PATCH 0/3] ARM/PSCI: Fix THUMB2_KERNEL entry points Florian Fainelli
2018-09-27 19:27 ` [PATCH 1/3] firmware/psci: Fix cpu_resume entry points with THUMB2_KERNEL Florian Fainelli
2018-09-28 13:47 ` Mark Rutland
2018-09-28 17:50 ` Florian Fainelli
2018-09-27 19:27 ` [PATCH 2/3] ARM: psci: Fix secondary core boot " Florian Fainelli
2018-09-28 13:48 ` Mark Rutland
2018-09-27 19:27 ` [PATCH 3/3] soc: bcm: brcmstb: Fix re-entry point with a THUMB2_KERNEL Florian Fainelli
2018-10-01 18:17 ` Florian Fainelli
2018-09-28 8:08 ` Robin Murphy [this message]
2018-09-28 17:51 ` [PATCH 0/3] ARM/PSCI: Fix THUMB2_KERNEL entry points Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c68b01ab-9077-73cc-8356-25a4e3a909f0@arm.com \
--to=robin.murphy@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=opendmb@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).