From: "yukuai (C)" <yukuai3@huawei.com>
To: <linus.walleij@linaro.org>, <baohua@kernel.org>,
<yuping.luo@csr.com>, <Markus.Elfring@web.de>
Cc: <linux-gpio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <yi.zhang@huawei.com>
Subject: Re: [PATCH V2] pinctrl: sirf: add missing put_device() call in sirfsoc_gpio_probe()
Date: Wed, 3 Jun 2020 09:39:15 +0800 [thread overview]
Message-ID: <c68e435a-30f7-c7ba-ec2e-93bcb17d2d26@huawei.com> (raw)
In-Reply-To: <20200603013532.755220-1-yukuai3@huawei.com>
On 2020/6/3 9:35, yu kuai wrote:
> A coccicheck run provided information like the following:
>
> drivers/pinctrl/sirf/pinctrl-sirf.c:798:2-8: ERROR: missing put_device;
> call of_find_device_by_node on line 792, but without a corresponding
> object release within this function.
>
> Generated by: scripts/coccinelle/free/put_device.cocci
>
> Thus add a jump target to fix the exception handling for this
> function implementation.
>
> Fixes: 5130216265f6 ("PINCTRL: SiRF: add GPIO and GPIO irq support in CSR SiRFprimaII")
> Signed-off-by: yu kuai <yukuai3@huawei.com>
> ---
> drivers/pinctrl/sirf/pinctrl-sirf.c | 20 ++++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
Sorry about the missing change log:
Changes in V2:
change the variant of commit message suggested by Markus.
Best Regards,
Yu Kuai
next prev parent reply other threads:[~2020-06-03 1:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 1:35 [PATCH V2] pinctrl: sirf: add missing put_device() call in sirfsoc_gpio_probe() yu kuai
2020-06-03 1:39 ` yukuai (C) [this message]
2020-06-03 12:32 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c68e435a-30f7-c7ba-ec2e-93bcb17d2d26@huawei.com \
--to=yukuai3@huawei.com \
--cc=Markus.Elfring@web.de \
--cc=baohua@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yuping.luo@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).