From: Zhou Yanjie <zhouyanjie@wanyeetech.com>
To: Paul Cercueil <paul@crapouillou.net>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-mips@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/3] pinctrl: ingenic: Fix bias config for X2000(E)
Date: Sat, 24 Jul 2021 14:42:58 +0800 [thread overview]
Message-ID: <c699e0a3-aa97-e8d8-ddfb-154f6d9344ce@wanyeetech.com> (raw)
In-Reply-To: <20210717174836.14776-2-paul@crapouillou.net>
Hi Paul,
On 2021/7/18 上午1:48, Paul Cercueil wrote:
> The ingenic_set_bias() function's "bias" argument is not a
> "enum pin_config_param", so its value should not be compared against
> values of that enum.
>
> This should fix the bias config not working on the X2000(E) SoCs.
>
> Fixes: 943e0da15370 ("pinctrl: Ingenic: Add pinctrl driver for X2000.")
> Cc: <stable@vger.kernel.org> # v5.12
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/pinctrl/pinctrl-ingenic.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Tested-by: 周琰杰 (Zhou Yanjie)<zhouyanjie@wanyeetech.com>
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c
> index 126ca671c3cd..263498be8e31 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -3441,17 +3441,17 @@ static void ingenic_set_bias(struct ingenic_pinctrl *jzpc,
> {
> if (jzpc->info->version >= ID_X2000) {
> switch (bias) {
> - case PIN_CONFIG_BIAS_PULL_UP:
> + case GPIO_PULL_UP:
> ingenic_config_pin(jzpc, pin, X2000_GPIO_PEPD, false);
> ingenic_config_pin(jzpc, pin, X2000_GPIO_PEPU, true);
> break;
>
> - case PIN_CONFIG_BIAS_PULL_DOWN:
> + case GPIO_PULL_DOWN:
> ingenic_config_pin(jzpc, pin, X2000_GPIO_PEPU, false);
> ingenic_config_pin(jzpc, pin, X2000_GPIO_PEPD, true);
> break;
>
> - case PIN_CONFIG_BIAS_DISABLE:
> + case GPIO_PULL_DIS:
> default:
> ingenic_config_pin(jzpc, pin, X2000_GPIO_PEPU, false);
> ingenic_config_pin(jzpc, pin, X2000_GPIO_PEPD, false);
next prev parent reply other threads:[~2021-07-24 6:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 17:48 [PATCH 1/3] pinctrl: ingenic: Fix incorrect pull up/down info Paul Cercueil
2021-07-17 17:48 ` [PATCH 2/3] pinctrl: ingenic: Fix bias config for X2000(E) Paul Cercueil
2021-07-24 6:42 ` Zhou Yanjie [this message]
2021-08-11 8:25 ` Linus Walleij
2021-07-17 17:48 ` [PATCH 3/3] pinctrl: ingenic: Add .max_register in regmap_config Paul Cercueil
2021-07-24 6:43 ` Zhou Yanjie
2021-08-11 8:25 ` Linus Walleij
2021-07-24 6:41 ` [PATCH 1/3] pinctrl: ingenic: Fix incorrect pull up/down info Zhou Yanjie
2021-08-11 8:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c699e0a3-aa97-e8d8-ddfb-154f6d9344ce@wanyeetech.com \
--to=zhouyanjie@wanyeetech.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).