From: Bart Van Assche <bvanassche@acm.org>
To: Kiwoong Kim <kwmad.kim@samsung.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, beanhuo@micron.com,
cang@codeaurora.org, adrian.hunter@intel.com, sc.suh@samsung.com,
hy50.seo@samsung.com, sh425.lee@samsung.com,
bhoon95.kim@samsung.com
Subject: Re: [PATCH v2 1/3] scsi: ufs: introduce vendor isr
Date: Mon, 13 Sep 2021 20:30:50 -0700 [thread overview]
Message-ID: <c6b2007b-155b-18b2-e45d-06f600c98797@acm.org> (raw)
In-Reply-To: <6801341a6c4d533597050eb1aaa5bf18214fc47f.1631519695.git.kwmad.kim@samsung.com>
On 9/13/21 00:55, Kiwoong Kim wrote:
> +static inline irqreturn_t
> +ufshcd_vendor_isr_def(struct ufs_hba *hba)
> +{
> + return IRQ_NONE;
> +}
Since "static inline irqreturn_t ufshcd_vendor_isr_def(struct ufs_hba
*hba)" occupies less than 80 columns please use a single line for the
declaration of this function. Additionally, please leave out the
"inline" keyword since modern compilers are good at deciding when to
inline a function and when not.
Thanks,
Bart.
next prev parent reply other threads:[~2021-09-14 3:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210913081148epcas2p21c23ca6a745f40083ee7d6e7da4d7c00@epcas2p2.samsung.com>
2021-09-13 7:55 ` [PATCH v2 0/3] scsi: ufs: introduce vendor isr Kiwoong Kim
[not found] ` <CGME20210913081150epcas2p11f98eed5939bf082981e2a4d6fd9a059@epcas2p1.samsung.com>
2021-09-13 7:55 ` [PATCH v2 1/3] " Kiwoong Kim
2021-09-14 3:30 ` Bart Van Assche [this message]
2021-09-14 5:13 ` Kiwoong Kim
2021-09-14 11:53 ` Avri Altman
2021-09-14 16:29 ` Bart Van Assche
[not found] ` <CGME20210913081151epcas2p453eb6c6de01466060724d1445b443572@epcas2p4.samsung.com>
2021-09-13 7:55 ` [PATCH v2 2/3] scsi: ufs: introduce force requeue Kiwoong Kim
[not found] ` <CGME20210913081152epcas2p2eac4a8dbef33164a150dccf2e282dcce@epcas2p2.samsung.com>
2021-09-13 7:55 ` [PATCH v2 3/3] scsi: ufs: ufs-exynos: implement exynos isr Kiwoong Kim
2021-09-13 16:23 ` Bart Van Assche
2021-09-14 5:12 ` Kiwoong Kim
2021-09-17 19:59 ` Avri Altman
2021-09-13 16:09 ` [PATCH v2 0/3] scsi: ufs: introduce vendor isr Bart Van Assche
2021-09-13 17:26 ` Alim Akhtar
2021-09-14 3:23 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6b2007b-155b-18b2-e45d-06f600c98797@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bhoon95.kim@samsung.com \
--cc=cang@codeaurora.org \
--cc=hy50.seo@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sc.suh@samsung.com \
--cc=sh425.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).