From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Deepa Dinamani <deepa.kernel@gmail.com>,
tglx@linutronix.de, john.stultz@linaro.org
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
y2038@lists.linaro.org, acme@kernel.org,
benh@kernel.crashing.org, catalin.marinas@arm.com,
cmetcalf@mellanox.com, cohuck@redhat.com, davem@davemloft.net,
deller@gmx.de, devel@driverdev.osuosl.org,
gerald.schaefer@de.ibm.com, gregkh@linuxfoundation.org,
heiko.carstens@de.ibm.com, hoeppner@linux.vnet.ibm.com,
hpa@zytor.com, jejb@parisc-linux.org, jwi@linux.vnet.ibm.com,
linux-mips@linux-mips.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
mark.rutland@arm.com, mingo@redhat.com, mpe@ellerman.id.au,
oberpar@linux.vnet.ibm.com, oprofile-list@lists.sf.net,
paulus@samba.org, peterz@infradead.org, ralf@linux-mips.org,
rostedt@goodmis.org, rric@kernel.org, schwidefsky@de.ibm.com,
sebott@linux.vnet.ibm.com, sparclinux@vger.kernel.org,
sth@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com,
will.deacon@arm.com, x86@kernel.org
Subject: Re: [PATCH v3 02/10] include: Move compat_timespec/ timeval to compat_time.h
Date: Mon, 5 Mar 2018 10:30:26 +0100 [thread overview]
Message-ID: <c6fb6676-a8d3-8893-660c-2b9899c5d5ab@de.ibm.com> (raw)
In-Reply-To: <20180116021818.24791-3-deepa.kernel@gmail.com>
On 01/16/2018 03:18 AM, Deepa Dinamani wrote:
> All the current architecture specific defines for these
> are the same. Refactor these common defines to a common
> header file.
>
> The new common linux/compat_time.h is also useful as it
> will eventually be used to hold all the defines that
> are needed for compat time types that support non y2038
> safe types. New architectures need not have to define these
> new types as they will only use new y2038 safe syscalls.
> This file can be deleted after y2038 when we stop supporting
> non y2038 safe syscalls.
You are now include a <linux/*.h> from several asm files
(
arch/arm64/include/asm/stat.h
arch/s390/include/asm/elf.h
arch/x86/include/asm/ftrace.h
arch/x86/include/asm/sys_ia32.h
)
It works, and it is done in many places, but it looks somewhat weird.
Would it make sense to have an asm-generic/compate-time.h instead? Asking for
opinions here.
>
> The patch also requires an operation similar to:
>
> git grep "asm/compat\.h" | cut -d ":" -f 1 | xargs -n 1 sed -i -e "s%asm/compat.h%linux/compat.h%g"
some comments from the s390 perspective:
> --- a/arch/s390/hypfs/hypfs_sprp.c
> +++ b/arch/s390/hypfs/hypfs_sprp.c
ok.
[...]
> --- a/arch/s390/include/asm/elf.h
> +++ b/arch/s390/include/asm/elf.h
> @@ -126,7 +126,7 @@
> */
>
> #include <asm/ptrace.h>
> -#include <asm/compat.h>
> +#include <linux/compat.h>
> #include <asm/syscall.h>
> #include <asm/user.h>
see above.
[...]
> --- a/arch/s390/kvm/priv.c
> +++ b/arch/s390/kvm/priv.c
ok
> --- a/arch/s390/pci/pci_clp.c
> +++ b/arch/s390/pci/pci_clp.c
ok
> --- a/drivers/s390/block/dasd_ioctl.c
> +++ b/drivers/s390/block/dasd_ioctl.c
ok
> --- a/drivers/s390/char/fs3270.c
> +++ b/drivers/s390/char/fs3270.c
ok
> --- a/drivers/s390/char/sclp_ctl.c
> +++ b/drivers/s390/char/sclp_ctl.c
ok
> --- a/drivers/s390/char/vmcp.c
> +++ b/drivers/s390/char/vmcp.c
ok
> --- a/drivers/s390/cio/chsc_sch.c
> +++ b/drivers/s390/cio/chsc_sch.c
ok
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -32,7 +32,7 @@
> #include <asm/chpid.h>
> #include <asm/io.h>
> #include <asm/sysinfo.h>
> -#include <asm/compat.h>
> +#include <linux/compat.h>
> #include <asm/diag.h>
> #include <asm/cio.h>
> #include <asm/ccwdev.h>
Can you move that into the other includes (where all the other <linux/*> includes are.
next prev parent reply other threads:[~2018-03-05 9:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 2:18 [PATCH v3 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion Deepa Dinamani
2018-01-16 2:18 ` [PATCH v3 01/10] compat: Make compat helpers independent of CONFIG_COMPAT Deepa Dinamani
2018-01-16 2:18 ` [PATCH v3 02/10] include: Move compat_timespec/ timeval to compat_time.h Deepa Dinamani
2018-01-16 9:30 ` Catalin Marinas
2018-01-16 15:34 ` Steven Rostedt
2018-03-02 21:57 ` James Hogan
2018-03-04 20:45 ` Helge Deller
2018-03-05 9:30 ` Christian Borntraeger [this message]
2018-03-06 12:46 ` Arnd Bergmann
2018-03-06 12:48 ` Christian Borntraeger
2018-03-06 22:58 ` Deepa Dinamani
2018-03-12 17:59 ` Deepa Dinamani
2018-01-16 2:18 ` [PATCH v3 03/10] compat: enable compat_get/put_timespec64 always Deepa Dinamani
2018-01-16 2:18 ` [PATCH v3 04/10] arch: introduce CONFIG_64BIT_TIME Deepa Dinamani
2018-01-16 2:18 ` [PATCH v3 05/10] arch: Introduce CONFIG_COMPAT_32BIT_TIME Deepa Dinamani
2018-01-16 2:18 ` [PATCH v3 06/10] posix-clocks: Make compat syscalls depend on CONFIG_COMPAT_32BIT_TIME Deepa Dinamani
2018-01-16 2:18 ` [PATCH v3 07/10] include: Add new y2038 safe __kernel_timespec Deepa Dinamani
2018-01-16 2:18 ` [PATCH v3 08/10] fix get_timespec64() for y2038 safe compat interfaces Deepa Dinamani
2018-01-16 2:18 ` [PATCH v3 09/10] change time types to new y2038 safe __kernel_* types Deepa Dinamani
2018-01-16 2:18 ` [PATCH v3 10/10] nanosleep: change time types to " Deepa Dinamani
2018-01-16 15:18 ` [PATCH v3 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6fb6676-a8d3-8893-660c-2b9899c5d5ab@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=acme@kernel.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=cmetcalf@mellanox.com \
--cc=cohuck@redhat.com \
--cc=davem@davemloft.net \
--cc=deepa.kernel@gmail.com \
--cc=deller@gmx.de \
--cc=devel@driverdev.osuosl.org \
--cc=gerald.schaefer@de.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hoeppner@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=jejb@parisc-linux.org \
--cc=john.stultz@linaro.org \
--cc=jwi@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=oberpar@linux.vnet.ibm.com \
--cc=oprofile-list@lists.sf.net \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=rostedt@goodmis.org \
--cc=rric@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=sth@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=ubraun@linux.vnet.ibm.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).