From: Sameer Pujar <spujar@nvidia.com>
To: <oder_chiou@realtek.com>, <tiwai@suse.com>, <perex@perex.cz>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: rt5659: add S32_LE format
Date: Wed, 22 Jan 2020 15:57:14 +0530 [thread overview]
Message-ID: <c700f22c-a053-7f39-dddf-41abe52cad77@nvidia.com> (raw)
In-Reply-To: <74a42452-f19c-1175-9928-da12ccad621d@nvidia.com>
Hi Reviewers,
Kindly review. Thanks.
On 1/20/2020 11:54 AM, Sameer Pujar wrote:
> Removing Bard(bardliao@realtek.com) from "to" list since I am getting
> undelivered message.
>
> Oder,
> Please add right folks as you feel necessary. Thanks.
>
> On 1/20/2020 11:47 AM, Sameer Pujar wrote:
>> ALC5659 supports maximum data length of 24-bit. Currently driver
>> supports
>> S24_LE which is a 32-bit container with valid data in [23:0] and 0s
>> in MSB.
>> S24_3LE is not commonly used and is hard to find audio streams with this
>> format. Also many SoC HW do not support S24_LE and S32_LE is used in
>> general. The 24-bit data can be represented in S32_LE [31:8] and 0s are
>> padded in LSB.
>>
>> This patch adds S32_LE to ALC5659 driver and data length for this is set
>> to 24 as per codec's maximum data length support. This helps to play
>> 24-bit audio, packed in S32_LE, on HW which do not support S24_LE.
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>> sound/soc/codecs/rt5659.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c
>> index fc74dd63..f910ddf 100644
>> --- a/sound/soc/codecs/rt5659.c
>> +++ b/sound/soc/codecs/rt5659.c
>> @@ -3339,6 +3339,7 @@ static int rt5659_hw_params(struct
>> snd_pcm_substream *substream,
>> val_len |= RT5659_I2S_DL_20;
>> break;
>> case 24:
>> + case 32:
>> val_len |= RT5659_I2S_DL_24;
>> break;
>> case 8:
>> @@ -3733,7 +3734,8 @@ static int rt5659_resume(struct
>> snd_soc_component *component)
>> #define RT5659_STEREO_RATES SNDRV_PCM_RATE_8000_192000
>> #define RT5659_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |
>> SNDRV_PCM_FMTBIT_S20_3LE | \
>> - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S8)
>> + SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE | \
>> + SNDRV_PCM_FMTBIT_S8)
>> static const struct snd_soc_dai_ops rt5659_aif_dai_ops = {
>> .hw_params = rt5659_hw_params,
next prev parent reply other threads:[~2020-01-22 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 6:17 [PATCH] ASoC: rt5659: add S32_LE format Sameer Pujar
2020-01-20 6:24 ` Sameer Pujar
2020-01-22 10:27 ` Sameer Pujar [this message]
2020-01-30 4:30 ` Oder Chiou
2020-01-31 3:20 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c700f22c-a053-7f39-dddf-41abe52cad77@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).