From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B03CC433F5 for ; Wed, 8 Dec 2021 12:35:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233484AbhLHMi4 (ORCPT ); Wed, 8 Dec 2021 07:38:56 -0500 Received: from mga12.intel.com ([192.55.52.136]:16627 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbhLHMiz (ORCPT ); Wed, 8 Dec 2021 07:38:55 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10191"; a="217845013" X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="217845013" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 04:35:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="461676250" Received: from mylly.fi.intel.com (HELO [10.237.72.56]) ([10.237.72.56]) by orsmga003.jf.intel.com with ESMTP; 08 Dec 2021 04:35:22 -0800 Message-ID: Date: Wed, 8 Dec 2021 14:35:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.3.2 Subject: Re: [PATCH v1 03/11] i2c: designware-pci: Use temporary variable for struct device Content-Language: en-US To: Andy Shevchenko , Wolfram Sang , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Cc: Mika Westerberg , Ajay Gupta References: <20211207192159.41383-1-andriy.shevchenko@linux.intel.com> <20211207192159.41383-3-andriy.shevchenko@linux.intel.com> From: Jarkko Nikula In-Reply-To: <20211207192159.41383-3-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/7/21 21:21, Andy Shevchenko wrote: > Use temporary variable for struct device to make code neater. > > While at it, rename variable of struct dw_i2c_dev pointer to i_dev. > > Signed-off-by: Andy Shevchenko > --- > drivers/i2c/busses/i2c-designware-pcidrv.c | 99 +++++++++++----------- > 1 file changed, 50 insertions(+), 49 deletions(-) > I think struct dw_i2c_dev *dev to *i_dev renaming would be better to do consistently through the all drivers/i2c/busses/i2c-designware-* or leave as is? Jarkko