From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B23DC33CB3 for ; Wed, 15 Jan 2020 11:19:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E53152187F for ; Wed, 15 Jan 2020 11:18:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g3Mcxwnk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729868AbgAOLS7 (ORCPT ); Wed, 15 Jan 2020 06:18:59 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:46852 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729057AbgAOLS6 (ORCPT ); Wed, 15 Jan 2020 06:18:58 -0500 Received: by mail-pf1-f194.google.com with SMTP id n9so8372173pff.13 for ; Wed, 15 Jan 2020 03:18:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=fXqQU6rEG13cTg0zIPcmRK0xunIDxm/XK6227+s03nA=; b=g3McxwnkUANkgahUsKI7co1RacshzyopeqJjkhK09l59YJUmMmGMx6/LWt3mOzcUO4 mw3t0NReHqJDSWcyPsbwbwjtA/tAjeFFeJpb5e+QJhaHuJT5ZiyiiXzqpZqrkwE0EL2T CSSa/Eeg+ZCYGW7arDj+xGWsXc3E+2liHsByajZb2107lndiT4wwOi127YPB8mAOWCwI JYHw14WoDEFoeNk9yxP1XtMEoYfEeGkkAI4nxW6PWcWzKHPBeiIyNOTNs1Jlcrwf9YyM 3v6UdXIs9DS4zqOWlKHOXCyhk5UflqruxB1yYtWiIFvxWMnGWsJHhnlEkD8+goIpAzad OQgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=fXqQU6rEG13cTg0zIPcmRK0xunIDxm/XK6227+s03nA=; b=s60O6ZRgf+y8yxwJPACDH+fBPd7fEH4gIoVCvZ4fd/CwbAFFiJDS/OlLAZDS+aeec+ LbF6EzchY1IG9cXTU1Pyg4T5OStN7iYneX1SS4cVoAY5hjrJzYeMSwmkEPUvCF/NqQ2C RxZX3Dc6/kR++pkuzKW9aJsWT82tHBT1/zrL76+rZwkUeITJmUnwHxplPVKXHOubqirl UtSXx4x92x4MMvhAW/sjh6YBWSwlHlg+cv9xYfduYCqWJEoeLLlPvkz6YSO4J7TusI9o WGJI1BS1btBjrzpzcRhx6JTjj1K0/rNfv055ny65/V1MjXR13QXtZVyRHHRv3biERKAm ax2A== X-Gm-Message-State: APjAAAVNNKSwBJIYjYAbZN29AaISd+AmrCJMAMnZnC2KMcctjUR33AB/ HLa6Ex2E4pvT/VGHxhwrb+mFmg== X-Google-Smtp-Source: APXvYqwzl+XFVZuDlxHINgXocwnPKmenS6n4tYr3MFMQB417i0lAf852X/6hrV3aU+jpJeUh7Th2Fw== X-Received: by 2002:a63:3409:: with SMTP id b9mr32626131pga.320.1579087137475; Wed, 15 Jan 2020 03:18:57 -0800 (PST) Received: from [10.79.0.170] ([45.135.186.87]) by smtp.gmail.com with ESMTPSA id a28sm21582026pfh.119.2020.01.15.03.18.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jan 2020 03:18:56 -0800 (PST) Subject: Re: [PATCH v11 2/4] uacce: add uacce driver To: Greg Kroah-Hartman Cc: Arnd Bergmann , Herbert Xu , jonathan.cameron@huawei.com, dave.jiang@intel.com, grant.likely@arm.com, jean-philippe , Jerome Glisse , ilias.apalodimas@linaro.org, francois.ozog@linaro.org, kenneth-lee-2012@foxmail.com, Wangzhou , "haojian . zhuang" , guodong.xu@linaro.org, linux-accelerators@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, iommu@lists.linux-foundation.org, Kenneth Lee , Zaibo Xu References: <1578710919-12141-1-git-send-email-zhangfei.gao@linaro.org> <1578710919-12141-3-git-send-email-zhangfei.gao@linaro.org> <20200111194006.GD435222@kroah.com> <053ccd05-4f11-5be6-47c2-eee5c2f1fdc4@linaro.org> <20200114145934.GA1960403@kroah.com> From: zhangfei Message-ID: Date: Wed, 15 Jan 2020 19:18:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200114145934.GA1960403@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Greg On 2020/1/14 下午10:59, Greg Kroah-Hartman wrote: > On Mon, Jan 13, 2020 at 11:34:55AM +0800, zhangfei wrote: >> Hi, Greg >> >> Thanks for the review. >> >> On 2020/1/12 上午3:40, Greg Kroah-Hartman wrote: >>> On Sat, Jan 11, 2020 at 10:48:37AM +0800, Zhangfei Gao wrote: >>>> +static int uacce_fops_open(struct inode *inode, struct file *filep) >>>> +{ >>>> + struct uacce_mm *uacce_mm = NULL; >>>> + struct uacce_device *uacce; >>>> + struct uacce_queue *q; >>>> + int ret = 0; >>>> + >>>> + uacce = xa_load(&uacce_xa, iminor(inode)); >>>> + if (!uacce) >>>> + return -ENODEV; >>>> + >>>> + if (!try_module_get(uacce->parent->driver->owner)) >>>> + return -ENODEV; >>> Why are you trying to grab the module reference of the parent device? >>> Why is that needed and what is that going to help with here? >>> >>> This shouldn't be needed as the module reference of the owner of the >>> fileops for this module is incremented, and the "parent" module depends >>> on this module, so how could it be unloaded without this code being >>> unloaded? >>> >>> Yes, if you build this code into the kernel and the "parent" driver is a >>> module, then you will not have a reference, but when you remove that >>> parent driver the device will be removed as it has to be unregistered >>> before that parent driver can be removed from the system, right? >>> >>> Or what am I missing here? >> The refcount here is preventing rmmod "parent" module after fd is opened, >> since user driver has mmap kernel memory to user space, like mmio, which may >> still in-use. >> >> With the refcount protection, rmmod "parent" module will fail until >> application free the fd. >> log like: rmmod: ERROR: Module hisi_zip is in use > But if the "parent" module is to be unloaded, it has to unregister the > "child" device and that will call the destructor in here and then you > will tear everything down and all should be good. > > There's no need to "forbid" a module from being unloaded, even if it is > being used. Look at all networking drivers, they work that way, right? Thanks Greg for the kind suggestion. I still have one uncertainty. Does uacce has to block process continue accessing the mmapped area when remove "parent" module? Uacce can block device access the physical memory when parent module call uacce_remove. But application is still running, and suppose it is not the kernel driver's responsibility to call unmap. I am looking for some examples in kernel, looks vfio does not block process continue accessing when vfio_unregister_iommu_driver either. In my test, application will keep waiting after rmmod parent, until ctrl+c, when unmap is called. During the process, kernel does not report any error. Do you have any advice? >>>> +static void uacce_release(struct device *dev) >>>> +{ >>>> + struct uacce_device *uacce = to_uacce_device(dev); >>>> + >>>> + kfree(uacce); >>>> + uacce = NULL; >>> That line didn't do anything :) >> Yes, this is a mistake. >> It is up to caller to set to NULL to prevent release multi times. > Release function is called by the driver core which will not touch the > value again. Yes, I understand, it's my mistake. Will remove it. Thanks